With the additional media search signals having made their way into a custom profile for existing search, we will no longer need the custom API.
Once the new profile is activate, we should remove the custom API & the new media search UI should query the existing search API.
The response from both APIs has been structured similarly and include the same information, so it's mostly just a matter of updating the request params.
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- T261815: MediaSearch: Search results depend on terms order
rGTWN726fba47ec6c: Wikibase Media Info: remove API module
T257295: Modify Special:MediaSearch to use the MediaQueryBuilder
T260722: Sort by filter for Media Search - Mentioned Here
- T262271: Activate mediasearch profile without requiring an explicit flag
T254388: Create interleaved A/B test for searching using new commons-specific elasticsearch query builder
T257295: Modify Special:MediaSearch to use the MediaQueryBuilder
Event Timeline
Comment Actions
@matthiasmullie can you clarify what the difference is between this task and T257295?
Comment Actions
T257295 has to go first - that one replaces the existing MediaSearch API logic to make it use the default search API (with MediaSearch profile). That way we can start to use the new backend without having to make & synchronize changes to the frontend.
Once that’s done, we can stop calling the MediaSearch API altogether from the frontend & remove the MediaSearch-specific endpoint.
Both shouldn’t really be too much work, the default API & MediaSearch API are very similar in input & output, and should require minimal change.
Comment Actions
This ticket is currently blocked - once the A/B test is complete (T254388) and we've confirmed that we're moving forward with the new profile, we can remove the URL param.
Comment Actions
Change 625892 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Remove MediaSearch API module, use existing search with MediaSearch profile
Comment Actions
This was blocked because the media search profile is not active unless explicitly requested (via mediasearch query param). This will not change until A/B test results confirm that we're not turning the search results into a total mess.
This ticket blocks a few others, though (e.g. ability to sort), so let's get this moving...
I have a patch up to make this work by explicitly calling out (for API) or checking (for initial results) that we want profile results from the mediasearch profile.
We'll just need to follow up after getting positive A/B test results to remove these (then) unnecessary checks/params (filed T262271)
Comment Actions
Change 625892 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Remove MediaSearch API module, use existing search with MediaSearch profile
Comment Actions
Change 627196 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[translatewiki@master] Wikibase Media Info: remove API module
Comment Actions
Change 627196 merged by jenkins-bot:
[translatewiki@master] Wikibase Media Info: remove API module
Comment Actions
Please inform translatewiki.net when adding or removing translation files. This way we can do changes beforehand before they show up in our error logs. You can tag translatewiki.net or ping @Raymond directly in Phabricator or Gerrit when it is about MediaWiki core or extensions.