ChangeMentorTest: Key "MaxNameChars" not found in input sources
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tgr
	Jul 15 2020, 4:19 PM

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-noselenium-docker/23876/console

16:11:34 There was 1 error:
16:11:34 
16:11:34 1) GrowthExperiments\ChangeMentorTest::testExecuteBadStatus
16:11:34 InvalidArgumentException: Key "MaxNameChars" not found in input sources
16:11:34 
16:11:34 /workspace/src/includes/config/ServiceOptions.php:52
16:11:34 /workspace/src/includes/ServiceWiring.php:1268
16:11:34 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
16:11:34 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
16:11:34 /workspace/src/includes/MediaWikiServices.php:1313
16:11:34 /workspace/src/includes/ServiceWiring.php:1240
16:11:34 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:447
16:11:34 /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php:416
16:11:34 /workspace/src/includes/MediaWikiServices.php:1289
16:11:34 /workspace/src/includes/user/User.php:598
16:11:34 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/ChangeMentorTest.php:129
16:11:34 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:110

Caused by rMW2d7d99f03674: Move User::newFromIdentity logic to UserFactory, presumably.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix testcase broken by core change	mediawiki/extensions/GrowthExperiments	REL1_35	+9 -7
	Fix testcase broken by core change	mediawiki/extensions/GrowthExperiments	master	+9 -7

Customize query in gerrit

Related Objects

Mentioned Here: rMW2d7d99f03674: Move User::newFromIdentity logic to UserFactory

Event Timeline

Tgr created this task.Jul 15 2020, 4:19 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 15 2020, 4:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Tgr claimed this task.Jul 15 2020, 4:20 PM

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.

Tgr moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr updated the task description. (Show Details)

Change 612998 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix testcase broken by core change

https://gerrit.wikimedia.org/r/612998

gerritbot added a project: Patch-For-Review.Jul 16 2020, 1:04 AM

Tgr moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 16 2020, 1:04 AM

Change 612998 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix testcase broken by core change

https://gerrit.wikimedia.org/r/612998

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 16 2020, 6:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2020, 6:10 AM

kostajh closed this task as Resolved.Jul 16 2020, 10:20 AM

Change 652945 had a related patch set uploaded (by Umherirrender; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@REL1_35] Fix testcase broken by core change

https://gerrit.wikimedia.org/r/652945

gerritbot added a project: Patch-For-Review.Jan 1 2021, 6:35 PM

Change 652945 merged by Umherirrender:
[mediawiki/extensions/GrowthExperiments@REL1_35] Fix testcase broken by core change