Page MenuHomePhabricator

Gerrit is giving tips on how to write comments, make sure it does not send our comments to some third party
Closed, ResolvedPublic

Description

There was a report that Gerrit is trying to "help" with writing respectful reviews, by showing a box like "Consider how comments may be interpreted." below the comment text area
with a link to a Google blog. See the area marked by the red arrow here:

The concern was whether or not our comments/replies/reviews are getting sent to a third party and are getting analyzed there.

Looking up the code, there are a few such recommendations, but they are triggered by a random number generator. Not through some third party service.
The relevant code is here:
https://github.com/GerritCodeReview/gerrit/blob/3164e069abf81fb125e62965f55c91f02b5bde95/polygerrit-ui/app/elements/shared/gr-comment/gr-comment.js#L284

So if we want to turn these "tips" off at some point, the above code (and the below html) can simply get edited away.

When clicking on Read more, the user is taken to https://testing.googleblog.com/2019/11/code-health-respectful-reviews-useful.html
If we want to change that target, we only need to adjust the href in
https://github.com/GerritCodeReview/gerrit/blob/3164e069abf81fb125e62965f55c91f02b5bde95/polygerrit-ui/app/elements/shared/gr-comment/gr-comment_html.js#L339

We could make it point to a mediawiki.org page for example.


Pasting all the "tips" that Gerrit wil give in this footer, so searching for them in Phabricator leads to this task:

  • Assume competence.
  • Provide rationale or context.
  • Consider how comments may be interpreted.
  • Avoid harsh language.
  • Make your comments specific and actionable.
  • When disagreeing, explain the advantage of your approach.

Event Timeline

QChris created this task.Jul 15 2020, 7:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2020, 7:47 PM
QChris closed this task as Resolved.Jul 15 2020, 7:48 PM
QChris claimed this task.

As explained in the bug description above, our comments/reviews/... are not getting sent to a third party. Hence, closing this bug.

This comment was removed by Aklapper.
This comment was removed by Aklapper.