Page MenuHomePhabricator

Set visibility policy of the Phabricator's Countdown application to "public"
Closed, ResolvedPublic

Assigned To
Authored By
valerio.bozzolan
Jul 15 2020, 8:43 PM
Referenced Files
F31937377: 3997CD60-54D8-46F9-9AAD-BF63DD4130E8.png
Jul 16 2020, 4:31 PM
F31937194: image.png
Jul 16 2020, 12:56 PM
F31936421: image.png
Jul 15 2020, 8:43 PM
Tokens
"Y So Serious" token, awarded by valerio.bozzolan."Like" token, awarded by Ferdi2005."Like" token, awarded by DannyS712."The World Burns" token, awarded by Sabas88.

Description

Countdown… what?

Phabricator is somehow a cornucopia of components. One of my favorites is called Countdown. This component literally creates a counter that—well—goes down.

This component fits a couple of needs like:

  • enfatize that "tic toc tic toc" sensation to respect a deployment deadline
  • remember when an event starts (e.g. the itWikiCon-2020)

Here a live example of the Countdown application in Wikimedia Phabricator:

image.png (676×938 px, 60 KB)

― from https://secure.phabricator.com/C145

Current situation

The "Can Use Application" of the Countdown application is set to "All (Registered) Users".

This historically made sense to prevent spam creations. Now it does not anymore since Visibility does not affect Creation anymore.

This is a problem: the Countdown application in Wikimedia Phabricator is not visible to logged-out users.nFor example, this section is not available when you are logged-out:

Problem affecting digital systems that store system time as a signed 32-bit integer.

DaysHoursMinutesSeconds
----
Jan 19 2038, 3:14 AM

Proposed change

  1. Go here: https://phabricator.wikimedia.org/applications/edit/PhabricatorCountdownApplication/
  2. Set Can Use Application = set to "Public (No Login Required)"

Actually this would be an appreciated change because @Aklapper kindly created a countdown for T255668: Create a countdown for itWikiCon 2020 call for papers but now the interesteds are not able to share that link and appreciate that work: even if the countdown itself is public, the application is visible only to registered users.

Bonus point: resolving this before Jul 30 23:58 will allow to enjoy the itWikiCon 2020 countdown. I mean, at least until Jul 30 23:59 :^)

Bonus point: resolving this before itWikiCon 2022 would be appreciated.

Bonus point: resolving this before the next itWikiCon 2023 would be appreciated. So, before 27 October 2023.

Bonus point: resolving this before Jan 19 2038, 04:14 would be appreciated. So before the Countdown "C4"

Event Timeline

For the records, I'm neutral on this request

mmodell claimed this task.
mmodell subscribed.

Done

Done

I don't want to spoil the party but it seems not done. Looking at C3:

Access Denied: Restricted Application
Users with the "Can View" capability:
Members of a particular project can take this action. (You can not see this object, so the name of this project is restricted.)

Also:

image.png (110×181 px, 7 KB)

This is not resolved, I can't see the C3 countdown.

This is not resolved, I can't see the C3 countdown.

Works fine here

https://phabricator.wikimedia.org/applications/view/PhabricatorCountdownApplication/ says
Can Use Application - Trusted-Contributors (Project)
Can Configure Application - Administrators
Default View Policy - Public (No Login Required)
Default Edit Policy - Trusted-Contributors (Project)

was created with visibility to All users and a custom edit policy (administrators, @valerio.bozzolan, and @Ferdi2005)
@Aklapper can the visibility of C3 be changed to public (no logic required)?

3997CD60-54D8-46F9-9AAD-BF63DD4130E8.png (2×1 px, 646 KB)

Ehm, this is when I try to view C3.

@Aklapper can the visibility of C3 be changed to public (no logic required)?

Done.

Checking the settings of the Countdown application itself its View Policy is set to public, hence resolving again.

Aklapper unsubscribed.

Ah, looks like the application's "Can Use Application" policy set to "Trusted-Contributors (Project)" overwrites the "Default View Policy" set to "Public (No Login Required)". (Personally I don't see why we should enable this application anyway.)

Ah, looks like the application's "Can Use Application" policy set to "Trusted-Contributors (Project)" overwrites the "Default View Policy" set to "Public (No Login Required)"

slowlydisappears

Well, sir, we have found a Phabricator cul-de-sac.

It seems it does not exist a way to allow everybody to see a Countdown, while limiting who can create a new one.

Someone said "please open another subtask"? Yes, of course!

Is there anything I can do for this? I would like to make this cute CountDown public:

Problem affecting digital systems that store system time as a signed 32-bit integer.

DaysHoursMinutesSeconds
----
Jan 19 2038, 3:14 AM

Thank you so much!

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan added a subscriber: Aklapper.
hashar claimed this task.
hashar subscribed.

I have changed Can Use Application from Trusted-Contributors to {Nav Public (No Login Required). Logged out I can then see the counter ticking at https://phabricator.wikimedia.org/C4

Due to this change, now literally everyone with an account can create countdowns. I hope we will not continue with that approach for random other Phab niche apps, given the vandalism and spam already seen in other niche apps when such app settings were chosen.

Ah my bad sorry. I think in my analyze of the permissions at https://phabricator.wikimedia.org/applications/view/PhabricatorCountdownApplication/ I have missed something:

Can Create CountdownsAll Users

I guess we can change the create permission to Trusted-Contributors ?

Ah my bad sorry. I think in my analyze of the permissions at https://phabricator.wikimedia.org/applications/view/PhabricatorCountdownApplication/ I have missed something:

Can Create CountdownsAll Users

I guess we can change the create permission to Trusted-Contributors ?

Yes. That was the intended situation inherited from T258599: Add a Phabricator policy capability "Can create Countdowns". The fact that now it's set to "All Users" it seems to me is just a default that was not intended to have.

All-Users was the default indeed. I have changed it to Trusted-Contributors