Page MenuHomePhabricator
Create Task
Maniphest T258107

Configure the no-jquery/no-global-selector rule in CheckUser by setting allowIds to true and remove exceptions
Closed, ResolvedPublic
Actions

Description

Problem
In several JavaScript files in CheckUser the no-jquery/no-global-selector rule is being completely disabled.

Proposed Solution
Change the configuration of the rule by setting allowIds to true then the rule can be used properly on all of the JavaScript files in CheckUser.

Details

SubjectRepoBranchLines +/-
Configure the no-jquery/no-global-selector rule & remove exceptionsmediawiki/extensions/CheckUsermaster+4 -14
Customize query in gerrit

Event Timeline

dbarratt created this task.Jul 15 2020, 8:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2020, 8:49 PM
• Tchanders added subscribers: • Tchanders, • Catrope, Esanders, Krinkle.Jul 15 2020, 8:51 PM
gerritbot added a comment.Jul 15 2020, 9:07 PM

Change 612951 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Configure the no-jquery/no-global-selector rule & remove exceptions

https://gerrit.wikimedia.org/r/612951

gerritbot added a project: Patch-For-Review.Jul 15 2020, 9:07 PM
• Tchanders removed subscribers: Krinkle, • Catrope.Jul 15 2020, 11:24 PM

Just realised that this is scoped to CheckUser. Apologies for the spam...

• Tchanders renamed this task from Configure the no-jquery/no-global-selector rule by setting allowIds to true and remove exceptions to Configure the no-jquery/no-global-selector rule in CheckUser by setting allowIds to true and remove exceptions.Jul 15 2020, 11:25 PM
gerritbot added a comment.Jul 16 2020, 3:07 PM

Change 612951 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Configure the no-jquery/no-global-selector rule & remove exceptions

https://gerrit.wikimedia.org/r/612951

Maintenance_bot removed a project: Patch-For-Review.Jul 16 2020, 3:10 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 16 2020, 4:00 PM
• Tchanders closed this task as Resolved.Jul 17 2020, 10:46 PM
• Tchanders claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits