Page MenuHomePhabricator
Create Task
Maniphest T258114

Deprecate Skin::getIndicatorsHTML
Closed, ResolvedPublic
Actions

Description

This doesn't appear to be used anywhere, so let's deprecate it. Going forward we want to move away from PHP string concatenation inside Skin.php and embrace templates.

Skins that don't wish to use Mustache should do this kind of skin concatenation themselves.

https://codesearch.wmcloud.org/search/?q=getIndicatorsHTML&i=nope&files=&repos=

Note: The line in WikimediaApiPortal Skin is actually commented out so no change there is needed.

Details

SubjectRepoBranchLines +/-
Deprecate Skin::getIndicatorsHTML()mediawiki/coremaster+6 -0
Remove commented-out codemediawiki/skins/WikimediaApiPortalmaster+0 -1
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jul 15 2020, 9:54 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 15 2020, 9:54 PM
Jdlrobson moved this task from Phase 3 - standardise template data to Phase 2 - Deprecate and remove Skin methods for readability on the MediaWiki-Core-Skin-Architecture board.Jul 15 2020, 11:32 PM
Ammarpad claimed this task.Jul 31 2020, 2:02 PM
gerritbot added a comment.Aug 4 2020, 9:52 AM

Change 618251 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Deprecate Skin::getIndicatorsHTML()

https://gerrit.wikimedia.org/r/618251

gerritbot added a project: Patch-For-Review.Aug 4 2020, 9:52 AM
gerritbot added a comment.Aug 4 2020, 10:08 AM

Change 618260 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/WikimediaApiPortal@master] Remove commented-out code

https://gerrit.wikimedia.org/r/618260

gerritbot added a comment.Aug 4 2020, 5:35 PM

Change 618260 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Remove commented-out code

https://gerrit.wikimedia.org/r/618260

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 4 2020, 6:00 PM
Jdlrobson triaged this task as High priority.Aug 4 2020, 8:46 PM
gerritbot added a comment.Aug 5 2020, 7:43 PM

Change 618251 merged by jenkins-bot:
[mediawiki/core@master] Deprecate Skin::getIndicatorsHTML()

https://gerrit.wikimedia.org/r/618251

Jdlrobson closed this task as Resolved.Aug 5 2020, 7:45 PM
Jdlrobson added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).

Thanks @Ammarpad! all done here.

Maintenance_bot removed a project: Patch-For-Review.Aug 5 2020, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL