Page MenuHomePhabricator
Create Task
Maniphest T258167

Variable/Template publishchanges is not expanded
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In the edit conflict page (not the talk page use case) there is a variable ⧼publishchanges⧽ that is not replaced:

image.png (118×673 px, 19 KB)

Details

SubjectRepoBranchLines +/-
Fix missing <publishchanges> message in tour dialogmediawiki/extensions/TwoColConflictmaster+1 -1
Customize query in gerrit

Event Timeline

• MichaelSchoenitzer_WMDE created this task.Jul 16 2020, 12:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2020, 12:48 PM
Aklapper renamed this task from Variable/Template is not expanded to Variable/Template publishchanges is not expanded.Jul 17 2020, 11:52 AM
Lena_WMDE set the point value for this task to 1.Jul 21 2020, 12:26 PM
Lena_WMDE moved this task from Backlog to Tickets ready for pickup on the Two-Column-Edit-Conflict-Merge board.
thiemowmde added a project: WMDE-QWERTY-Sprint-2020-07-22.Jul 22 2020, 7:20 AM
thiemowmde subscribed.
gerritbot added a comment.Jul 22 2020, 10:51 AM

Change 615425 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Fix missing <publishchanges> message in tour dialog

https://gerrit.wikimedia.org/r/615425

gerritbot added a project: Patch-For-Review.Jul 22 2020, 10:51 AM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-07-22 board.Jul 22 2020, 10:51 AM
gerritbot added a comment.Jul 23 2020, 9:04 AM

Change 615425 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Fix missing <publishchanges> message in tour dialog

https://gerrit.wikimedia.org/r/615425

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2020, 9:10 AM
Andrew-WMDE moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-07-22 board.Jul 23 2020, 9:42 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 23 2020, 10:00 AM
Lena_WMDE closed this task as Resolved.Aug 11 2020, 9:08 AM
Lena_WMDE claimed this task.
Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-07-22 board.Aug 11 2020, 9:17 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits