Page MenuHomePhabricator

API:Move does not unwatch page you are moving to if "unwatch" selected
Open, LowestPublicBUG REPORT

Description

What is the problem?

If I am watching Page_A and I use the API to move it to Page_B and I select the watchlist parameter unwatch:

  • Page_A is unwatched
  • Page_B is watched

It seems more consistent with the unwatch option that both should be unwatched.

Steps to reproduce problem
  1. Go to any page and watch it (does not matter if permanently or temporarily)
  2. Use the API to move the page, selecting for the "watchlist" parameter "unwatch" (e.g. on beta you could use the sandbox: https://en.wikipedia.beta.wmflabs.org/wiki/Special:ApiSandbox#action=move&format=json&from=TemplateUsageArticle820&to=TemplateUsageArticle820_moved&watchlist=unwatch)

Expected behavior: Both the old and new pages are unwatched
Observed behavior: The old page is unwatched, the new page is watched

Environment

Wiki(s): Beta: MediaWiki 1.36.0-alpha (fbfa8f1) 12:47, 16 July 2020

Event Timeline

Restricted Application added a project: Platform Engineering. · View Herald TranscriptJul 16 2020, 3:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dom_walden renamed this task from API:Move does not unwatch page you are moving to even if "unwatch" selected to API:Move does not unwatch page you are moving to if "unwatch" selected.Jul 16 2020, 3:43 PM

For the record, the same behaviour happens at Special:MovePage as well with the "Watch source page and target page" checkbox. I guess the thought is that if you were watching the old page you surely want to watch the new one, the only question being if you still wanted to watch the old one.

For the API specifically, I agree "unwatch" here is ambiguous, but it does seem to be long-standing behaviour.

eprodromou triaged this task as Lowest priority.Jul 21 2020, 8:44 PM
eprodromou added a subscriber: eprodromou.

We've reviewed this on Platform team and we think that if the API is behaving the same as the Web UI, that's probably for the best. We're accepting for Clinic Duty for review, but we're likely to decline this issue in the end.

eprodromou added a subscriber: nnikkhoui.

@nnikkhoui to review further, possibly.

ifried added a subscriber: ifried.Jul 30 2020, 3:39 PM

As this is longstanding behavior, Community Tech will not be fixing this issue in the scope of the Watchlist Expiry project.