In an attempt to do a bit of organization to parsing code, the introduction of an IParser interface was made to declare methods within classes that implement it.
Is this something useful in the long run related to parser code?
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [parser][edit] Introduce IParser interface with `getOutput()` method | mediawiki/core | master | +37 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T261329 Prepare Parsoid for MW | |||
| Open | None | T236809 Refactor Parser.php to allow alternate parser (Parsoid) | |||
| Open | None | T236812 Parser.php should be split into a base class and a parser implementation | |||
| Invalid | None | T258226 Introduce IParser interface with `getOutput()` method for implementation |
Change 531314 had a related patch set uploaded (by D3r1ck01; owner: Derick Alangi):
[mediawiki/core@master] [parser][edit] Introduce IParser interface with getOutput() method
See my comments on the patch. The IParser interface seems misnamed, since it is really a "ParserOutput getter" interface, and it is only used in three places: Parser, a Parser mock, and a deprecated class that will likely be removed in 1.36. Doesn't quite seem worthwhile.
Change 531314 abandoned by D3r1ck01:
[mediawiki/core@master] [parser][edit] Introduce IParser interface with getOutput() method
Reason:
will rethink this again and propose when ready
Actually removing includes/edit/PreparedEdit would be nice! Although that's probably a lot more work...