Rethink the license, source and author fields in Upload view
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	01tonythomas
	Jul 17 2020, 9:44 AM

Description

So, we have the license dropdown now at the uploader. However, this is still not in sync with https://commons.wikimedia.org/wiki/Special:UploadWizard sadly. Some issues I see:

Selecting the license to own source still requires source and author
UploadWizard lets you chose the license string when you own the object, for eg:

Screenshot 2020-07-17 at 11.38.18.png (385×1 px, 77 KB)

This might be a bit more tricky task, but lets iterate like this ?

Make source and author not mandatory for starters. You can still throw an error from the backend when the license is not "my own work" and these fields are missing. We need to get T258247 in there first
Make "Source and Author" only show up when you select one of those licenses that are not part of "My own work" at the front-end.
Add an extra field to the serializer and collect the custom license string when you select "My own work"

Details

	Subject	Repo	Branch	Lines +/-
	add: Input Validation and Release Rights Selection	labs/tools/gdrive-to-commons	master	+261 -190

Customize query in gerrit

Related Objects

Mentioned Here: T258247: Show file upload errors per file on the upload view

Event Timeline

01tonythomas created this task.Jul 17 2020, 9:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2020, 9:44 AM

Won't it be better if we tackle with "my own work" at the frontend itself?
If the user selects "my own work", we can auto-fill the source to {{own}} and author to the username ({{user.username}}).
I think this will help us not to modify and backend logic and we can handle the validation on the frontend.
Thoughts? @01tonythomas

function ownWork(userSelection) {
      var isTrueSet = (userSelection.value == 'true');
      if (isTrueSet){
          document.getElementById("author"+id).value = "{{ user.username }]";
          document.getElementById("author-block"+id).style.display = "none";

          document.getElementById("source"+id).value = "{{own}}";
          document.getElementById("source-block"+id).style.display = "none";
      } else {

         document.getElementById("author"+id).value = "";
          document.getElementById("author-block"+id).style.display = "block";

          document.getElementById("source"+id).value = "";
          document.getElementById("source-block"+id).style.display = "block";
      }
  }

I have implemented this and it seems to work fine. Just need to clean up the code a little bit. Let me know if I should try the other approach?

Change 615589 had a related patch set uploaded (by Abbasidaniyal; owner: Abbasidaniyal):
[labs/tools/gdrive-to-commons@master] add: Input Validation and Release Rights Selection

https://gerrit.wikimedia.org/r/615589

gerritbot added a project: Patch-For-Review.Jul 23 2020, 12:02 AM

Abbasidaniyal closed this task as Resolved.Jul 30 2020, 8:48 PM

Change 615589 merged by jenkins-bot:
[labs/tools/gdrive-to-commons@master] add: Input Validation and Release Rights Selection