Page MenuHomePhabricator

Argument 1 passed to ManualLogEntry::setTarget() must implement interface MediaWiki\Linker\LinkTarget
Closed, ResolvedPublic

Description

2020-07-17 01:28:13 mw4 mini1wiki: [93c4354821fd9eab01c0a661] /w/api.php   TypeError from line 142 of /srv/mediawiki/w/includes/logging/ManualLogEntry.php: Argument 1 passed to ManualLogEntry::setTarget() must implement interface MediaWiki\Linker\LinkTarget, null given, called in /srv/mediawiki/w/extensions/Comments/includes/Comment.php on line 701
#0 /srv/mediawiki/w/extensions/Comments/includes/Comment.php(701): ManualLogEntry->setTarget(NULL)
#1 /srv/mediawiki/w/extensions/Comments/includes/Comment.php(330): Comment::log(string, User, string, integer, string)
#2 /srv/mediawiki/w/extensions/Comments/includes/api/CommentSubmitAPI.php(41): Comment::add(string, CommentsPage, User, string)
#3 /srv/mediawiki/w/includes/api/ApiMain.php(1601): CommentSubmitAPI->execute()
#4 /srv/mediawiki/w/includes/api/ApiMain.php(537): ApiMain->executeAction()
#5 /srv/mediawiki/w/includes/api/ApiMain.php(508): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/w/api.php(87): ApiMain->execute()
#7 {main}

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 613731 had a related patch set uploaded (by Jack Phoenix; owner: Jack Phoenix):
[mediawiki/extensions/Comments@master] Validate the page ID early on in the comment submission API module to prevent TypeErrors

https://gerrit.wikimedia.org/r/613731

Change 613731 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Validate the page ID early on in the comment submission API module to prevent TypeErrors

https://gerrit.wikimedia.org/r/613731

Paladox assigned this task to ashley.