Page MenuHomePhabricator

setTemporaryHook() to accept both new and old hook names
Closed, DeclinedPublic


When the new Hook system was implemented, hook names with colons were replace with underscores.
E.g. onContribsPager::reallyDoQuery to onContribsPager__reallyDoQuery.

It seems expected, that if an extension has a hook registered in the old format, calling setTemporaryHook() on the hook in the new format should still override the hook. This behavior does not occur as it stands and should be implemented.

Event Timeline

Change 613730 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] setTemporaryHook() accept new and old style hook names

Change 613730 abandoned by Nikki Nikkhoui:
[mediawiki/core@master] WIP: setTemporaryHook() accept new and old style hook names

Different Approach

Tagging the platform team for triage. I think this qualifies as a "small project", and it should have high priority, since we need this to enable extensions to effectively and confidently use the new hook system.