Page MenuHomePhabricator

Remove repo only parts from EntityChange
Closed, ResolvedPublic

Description

In order to factor out EntityChange as a standalone library we should remove calls that are only made from Repo

The only changes are made in:

  • setRevisionInfo
  • setMetadataFromRC
  • setMetadataFromUser

Some random ideas for what to do:

  • Create a new class inheriting from EntityChange in Repo to add the setRevisionInfo method only in Repo
  • Try to remove all setter methods and instead move the logic to the Factory
  • maybe we can extract the “setter” part and leave that in Lib, but move the rest of EntityChange and ClientChange to the separate package? (from https://phabricator.wikimedia.org/T257439#6315632)

Event Timeline

Tarrow created this task.Jul 20 2020, 10:33 AM
Tarrow renamed this task from Remove setRevisionInfo from EntityChange to Remove repo only parts from EntityChange.Jul 20 2020, 12:45 PM
Tarrow updated the task description. (Show Details)

Change 615153 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Extract Repo only parts of EntityChange

https://gerrit.wikimedia.org/r/615153

Change 615153 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Extract Repo only parts of EntityChange

https://gerrit.wikimedia.org/r/615153

Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 6 2020, 4:32 PM

This causes a test warning (T259814), but apart from that this seems to work, so I think we can close this task.