Change instances of MWException to be a plain Exception
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Tarrow
	Jul 20 2020, 12:52 PM

Description

We don't want to depend on MW so we should throw a built-in exception.

We checked and we don't need to implement some kind of "isLoggable()". the MWExceptionHandler already seems to do the right thing.

Details

	Subject	Repo	Branch	Lines +/-
	Change instances of MWException to be a plain Exception in Lib\Changes	mediawiki/extensions/Wikibase	master	+39 -39

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T256058 Extract PHP package/library for "changes" as a "subtree" from the Wikibase monorepo
		Resolved		Ladsgroup	T258393 Change instances of MWException to be a plain Exception

Event Timeline

Tarrow created this task.Jul 20 2020, 12:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2020, 12:52 PM

Ladsgroup claimed this task.Jul 21 2020, 9:52 AM

Ladsgroup moved this task from Backlog to Doing on the Wikibase Extension Decoupling and Registration (Sprint 3) board.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 21 2020, 9:52 AM

Change 615207 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Change instances of MWException to be a plain Exception in Lib\Changes

https://gerrit.wikimedia.org/r/615207

gerritbot added a project: Patch-For-Review.Jul 21 2020, 12:22 PM

Ladsgroup moved this task from Doing to Peer Review on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 21 2020, 12:31 PM

Change 615207 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Change instances of MWException to be a plain Exception in Lib\Changes

https://gerrit.wikimedia.org/r/615207

Lucas_Werkmeister_WMDE moved this task from Peer Review to Verification on the Wikibase Extension Decoupling and Registration (Sprint 3) board.Jul 21 2020, 4:33 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 21 2020, 5:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 21 2020, 6:01 PM

darthmon_wmde edited projects, added Wikibase Extension Decoupling and Registration (Sprint 4); removed Wikibase Extension Decoupling and Registration (Sprint 3).Aug 4 2020, 9:29 AM

darthmon_wmde moved this task from Backlog to Verification on the Wikibase Extension Decoupling and Registration (Sprint 4) board.

Ladsgroup closed this task as Resolved.Aug 5 2020, 9:08 AM

Ladsgroup moved this task from Verification to Done on the Wikibase Extension Decoupling and Registration (Sprint 4) board.

Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Aug 5 2020, 9:15 AM