Page MenuHomePhabricator

MenuTagMultiselect adds items twice if specified as options and selected options
Closed, ResolvedPublic

Description

The MenuTagMultiselectWidget has the following config (among others):

  • options specifies the options that can appear in the menu
  • selected specifies the options that are pre-selected

I would expect options to be a superset of selected, but if an item is specified in both, it appears twice in the menu, with the second version appearing blank:

image.png (555×746 px, 33 KB)

Event Timeline

Change 617753 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] OO.ui.MenuTagMultiselectWidget: Fix handling of options configs

https://gerrit.wikimedia.org/r/617753

Change 617753 merged by jenkins-bot:
[oojs/ui@master] OO.ui.MenuTagMultiselectWidget: Fix handling of options configs

https://gerrit.wikimedia.org/r/617753

Change 618983 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.1

https://gerrit.wikimedia.org/r/618983

Change 618983 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.1

https://gerrit.wikimedia.org/r/618983

Volker_E triaged this task as Medium priority.
Volker_E moved this task from Reviewing to OOUI-0.40.1 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.40.1); removed OOUI.
Volker_E removed a project: Patch-For-Review.