Page MenuHomePhabricator
Create Task
Maniphest T258428

TypeError: element is undefined (from OO.ui.mixin.AccessKeyedElement)
Closed, ResolvedPublic
Actions

Description

example
Logstash

Occurred on https://ca.wikipedia.org/w/index.php?title=Plantilla:Infotaula_eleccions/presentablocs&action=submit
I can trace this to the VisualEditor method to OO.ui.mixin.AccessKeyedElement.prototype.formatTitleWithAccessKey which appears to be calling getAccessKeyLabel with an undefined element.

TypeError: element is undefined

at getAccessKeyLabel URL1:1612:765
at OO.ui.mixin.AccessKeyedElement.prototype.formatTitleWithAccessKey URL1:859:838
at OO.ui.mixin.TitledElement.prototype.updateTitle URL1:858:259
at OoUiMixinAccessKeyedElement URL1:858:724
at OoUiInputWidget URL1:934:781
at OoUiTextInputWidget URL1:953:980
at OO.ui.Element.static.unsafeInfuse URL1:825:492
at OO.ui.Element.static.infuse URL1:823:285
at OO.ui.infuse URL1:819:885
at URL1:1637:767
at mightThrow URL1:594:149
at resolve/</process< URL1:594:808

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update OOUI to v0.40.3mediawiki/coremaster+254 -121
Update OOUI to v0.40.2mediawiki/coremaster+179 -98
Follow-up I669cfeeb: Fix the removing of windows being broken by `this` scoping issueoojs/uimaster+17 -2
InputWidget: Fix infusion when something removes the 'oo-ui-inputWidget-input' classoojs/uimaster+5 -2
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jul 20 2020, 6:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2020, 6:13 PM
Jdlrobson updated the task description. (Show Details)Jul 20 2020, 6:22 PM
Krinkle moved this task from Untriaged to Jul 2020 on the Wikimedia-production-error board.Jul 22 2020, 6:04 PM
Jdlrobson renamed this task from TypeError: element is undefined to TypeError: element is undefined (getAccessKeyLabel).Aug 3 2020, 3:43 PM
Jdlrobson updated the task description. (Show Details)
Umherirrender added a project: JavaScript.Aug 5 2020, 9:41 PM
gerritbot added a comment.Aug 19 2020, 5:44 PM

Change 621327 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] InputWidget: Fix infusion when something removes the 'oo-ui-inputWidget-input' class

https://gerrit.wikimedia.org/r/621327

gerritbot added a project: Patch-For-Review.Aug 19 2020, 5:44 PM
• matmarex claimed this task.Aug 19 2020, 5:49 PM
gerritbot added a comment.Aug 19 2020, 6:16 PM

Change 621327 merged by jenkins-bot:
[oojs/ui@master] InputWidget: Fix infusion when something removes the 'oo-ui-inputWidget-input' class

https://gerrit.wikimedia.org/r/621327

Jdlrobson closed this task as Resolved.Aug 19 2020, 6:42 PM

I can reopen if I see the issue reoccur after Wednesday next week

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 19 2020, 6:42 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 19 2020, 7:10 PM
gerritbot added a comment.Aug 21 2020, 11:54 AM

Change 621711 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.2

https://gerrit.wikimedia.org/r/621711

gerritbot added a project: Patch-For-Review.Aug 21 2020, 11:54 AM
Reedy mentioned this in T245824: Error in "App closes on clicking the cancel button".Aug 22 2020, 4:31 PM
gerritbot added a comment.Aug 24 2020, 9:55 AM

Change 621989 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[oojs/ui@master] Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

gerritbot added a comment.Aug 24 2020, 1:06 PM

Change 621989 merged by jenkins-bot:
[oojs/ui@master] Follow-up I669cfeeb: Fix the removing of windows being broken by this scoping issue

https://gerrit.wikimedia.org/r/621989

gerritbot added a comment.Sep 2 2020, 3:58 PM

Change 623824 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

gerritbot added a comment.Sep 3 2020, 2:36 AM

Change 621711 abandoned by Reedy:
[mediawiki/core@master] Update OOUI to v0.40.2

Reason:
Replaced by https://gerrit.wikimedia.org/r/c/mediawiki/core/ /623824

https://gerrit.wikimedia.org/r/621711

gerritbot added a comment.Sep 9 2020, 2:19 PM

Change 623824 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.3

https://gerrit.wikimedia.org/r/623824

Jdlrobson reopened this task as Open.Sep 14 2020, 9:28 PM

Still seeing this e.g. https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.09.14/clienterror/?id=AXSMgLSsMQ_08tQa-xKk, but hopefully it will be fixed in this weeks deploy?

Krinkle renamed this task from TypeError: element is undefined (getAccessKeyLabel) to TypeError: element is undefined (from OO.ui.mixin.AccessKeyedElement).Sep 22 2020, 12:41 AM
Krinkle updated the task description. (Show Details)
JTannerWMF added a project: Editing-team (Kanban Board).Sep 22 2020, 3:33 PM
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.
JTannerWMF subscribed.

@matmarex will take a look

JTannerWMF moved this task from Inbox to Doing on the Editing-team (Kanban Board) board.Sep 22 2020, 3:34 PM
• matmarex closed this task as Resolved.EditedSep 22 2020, 7:42 PM

Looks fixed. Here's a cute chart of errors containing "element is undefined": https://logstash.wikimedia.org/goto/97d07a09a0d009f3bc329af0d995091c

image.png (1×2 px, 107 KB)

The last results are on 2020-09-17 (last Thursday), then nothing.

• matmarex removed projects: Editing-team (Kanban Board), Patch-For-Review, VisualEditor.Sep 22 2020, 7:42 PM

(this was not a VisualEditor issue)

Jdlrobson awarded a token.Sep 22 2020, 9:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits