Watchlist Expiry: "Uncaught Error: Widget not found" JS error in edit page form when user is not logged in
Closed, ResolvedPublic
Actions

Description

When an user is not logged in, there is a JS error in the edit page form when watchlist expiry feature is turned on.

Uncaught Error: Widget not found

Details

Project	Branch	Lines +/-	Subject
mediawiki/core	REL1_35	+2 -2	Fix expiry dropdown not getting disabled on edit page.
mediawiki/core	REL1_35	+18 -13	Fix js error on edit page when user is not logged in
mediawiki/core	master	+2 -2	Fix expiry dropdown not getting disabled on edit page.
mediawiki/core	master	+18 -13	Fix js error on edit page when user is not logged in

Customize query in gerrit

Related Objects

Mentioned In: T259052: Watchlist Expiry: Fix issue of watchlist expiry dropdown being disabled in source editing
Mentioned Here: T248494: Watchlist Expiry: Implement Support for Edit Functionality (desktop view) [medium]
rMW0fed18bf184d: Localisation updates from https://translatewiki.net.

Event Timeline

HMonroy created this task.Jul 20 2020, 8:07 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptJul 20 2020, 8:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

HMonroy updated the task description. (Show Details)Jul 20 2020, 8:09 PM

Aklapper renamed this task from Watchlist Expiry: Fix JS error in edit page form when user is not logged in to Watchlist Expiry: "Uncaught Error: Widget not found" JS error in edit page form when user is not logged in.Jul 20 2020, 8:24 PM

ifried moved this task from New & TBD Tickets to To Be Estimated/Discussed on the Community-Tech board.Jul 20 2020, 10:36 PM

Change 615301 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Fix js error on edit page when user is not logged in

https://gerrit.wikimedia.org/r/615301

gerritbot added a project: Patch-For-Review.Jul 21 2020, 8:41 PM

dmaza claimed this task.Jul 22 2020, 3:29 PM

dmaza moved this task from To Be Estimated/Discussed to Kanban-2020-21-Q1 on the Community-Tech board.

dmaza edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.

dmaza moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q1) board.

dmaza moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.

Change 615301 merged by jenkins-bot:
[mediawiki/core@master] Fix js error on edit page when user is not logged in

https://gerrit.wikimedia.org/r/615301

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 22 2020, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 22 2020, 11:10 PM

BEANS-X2 added a subscriber: BEANS-X2.Jul 23 2020, 1:27 PM

dmaza moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 24 2020, 8:39 PM

@dmaza I notice the expiry dropdown is not disabled when the watch checkbox is unchecked.

I think here, document.getElementById( 'wpWatchThisWidget' ) needs to be document.getElementById( 'wpWatchthisWidget' ) (different capitalisation). The former returns null for me when I run it in the browser console on the edit page.

In T258443#6336722, @dom_walden wrote:

@dmaza I notice the expiry dropdown is not disabled when the watch checkbox is unchecked.

I think here, document.getElementById( 'wpWatchThisWidget' ) needs to be document.getElementById( 'wpWatchthisWidget' ) (different capitalisation). The former returns null for me when I run it in the browser console on the edit page.

Good catch. I’ll fix it. Thank you.

dom_walden mentioned this in T259052: Watchlist Expiry: Fix issue of watchlist expiry dropdown being disabled in source editing.Jul 28 2020, 5:25 PM

Change 616893 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@master] Fix expiry dropdown not getting disabled on edit page.

https://gerrit.wikimedia.org/r/616893

gerritbot added a project: Patch-For-Review.Jul 28 2020, 7:12 PM

Change 616893 merged by jenkins-bot:
[mediawiki/core@master] Fix expiry dropdown not getting disabled on edit page.

https://gerrit.wikimedia.org/r/616893

Change 616970 had a related patch set uploaded (by Samwilson; owner: Dmaza):
[mediawiki/core@REL1_35] Fix js error on edit page when user is not logged in

https://gerrit.wikimedia.org/r/616970

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.3; 2020-08-04); removed MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 29 2020, 4:00 AM

Change 616970 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix js error on edit page when user is not logged in

https://gerrit.wikimedia.org/r/616970

ReleaseTaggerBot added a project: MW-1.35-notes.Jul 29 2020, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 5:10 AM

While logged out, no watchlist related javascript gets loaded when editing or previewing. No issues editing with either source or visual editor.

While logged in, the dropdown in the source editor behaves the same way as it did in T248494.

In case of regression, I tested I could submit an edit via visual editor while logged in and it successfully permanently watched the page.

Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (0fed18b) 06:34, 30 July 2020

In T258443#6343402, @gerritbot wrote:

Change 616893 merged by jenkins-bot:
[mediawiki/core@master] Fix expiry dropdown not getting disabled on edit page.

https://gerrit.wikimedia.org/r/616893

@dmaza Does this need to be backported as well?

Change 617582 had a related patch set uploaded (by Dmaza; owner: Dmaza):
[mediawiki/core@REL1_35] Fix expiry dropdown not getting disabled on edit page.

https://gerrit.wikimedia.org/r/617582

gerritbot added a project: Patch-For-Review.Jul 31 2020, 5:05 PM

In T258443#6352213, @dom_walden wrote:

In T258443#6343402, @gerritbot wrote:

Change 616893 merged by jenkins-bot:
[mediawiki/core@master] Fix expiry dropdown not getting disabled on edit page.

https://gerrit.wikimedia.org/r/616893

@dmaza Does this need to be backported as well?

Yes, thank you.

I tested this issue, and I did not the previous error occur when trying to edit (as a not logged in user) when watchlist expiry was turned on (on testwiki). For this reason, I'm marking it as Done.

Change 617582 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix expiry dropdown not getting disabled on edit page.