Page MenuHomePhabricator
Create Task
Maniphest T258444

iw.toolforge.org strips query parameters when redirecting
Closed, ResolvedPublicBUG REPORT
Actions

Description

user@dev ~> curl -I 'https://iw.toolforge.org/checker/?db=enwikisource_p&title=Index:Bon-Accord_Sangster.pdf'
...
location: https://checker.toolforge.org/

Related Objects

Event Timeline

Legoktm created this task.Jul 20 2020, 8:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2020, 8:11 PM
bd808 claimed this task.Jul 20 2020, 8:12 PM
bd808 added a project: cloud-services-team (Kanban).

The redirect needs $request_uri appended to propagate query parameters.

Restricted Application added a project: User-bd808. · View Herald TranscriptJul 20 2020, 8:12 PM
Stashbot added a comment.Jul 20 2020, 8:13 PM

Mentioned in SAL (#wikimedia-cloud) [2020-07-20T20:13:54Z] <wm-bot> <bd808> Updated ingress to use $request_uri when redirecting (T258444)

Nintendofan885 subscribed.Jul 20 2020, 8:17 PM
This comment was removed by Nintendofan885.
Nintendofan885 added a comment.Jul 20 2020, 8:19 PM

Now it seems to go to https://checker.toolforge.org//checker/?db=enwikisource_p&title=Index:Bon-Accord_Sangster.pdf

Legoktm added a comment.Jul 20 2020, 8:20 PM
In T258444#6320950, @Nintendofan885 wrote:

Now it seems to go to https://checker.toolforge.org//checker/?db=enwikisource_p&title=Index:Bon-Accord_Sangster.pdf

Yes, we're still working on it on IRC.

Stashbot added a comment.Jul 20 2020, 8:20 PM

Mentioned in SAL (#wikimedia-cloud) [2020-07-20T20:20:14Z] <wm-bot> <bd808> Updated ingress to use $args rather than $request_uri when redirecting (T258444)

Stashbot added a comment.Jul 20 2020, 8:21 PM

Mentioned in SAL (#wikimedia-cloud) [2020-07-20T20:21:51Z] <wm-bot> <bd808> Updated ingress to add $is_args when redirecting (T258444)

Nintendofan885 added a comment.Jul 20 2020, 8:23 PM

It's redirecting correctly now

bd808 closed this task as Resolved.Jul 20 2020, 8:24 PM

Updated docs at https://wikitech.wikimedia.org/w/index.php?title=Tool:Iw&diff=1874541 with new running config

LucasWerkmeister mentioned this in T345783: iw.toolforge.org does not support URL-encoded query parameters ([[toolforge:foo?bar]]).Sep 6 2023, 10:51 PM
bd808 added a project: Tool-iw.Sep 11 2023, 8:34 PM
bd808 changed the subtype of this task from "Task" to "Bug Report".Oct 19 2023, 2:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL