Page MenuHomePhabricator

Bugfix for get_lock() function on fran1001 inserts
Closed, ResolvedPublic

Description

Currently not running as expected; function needed to prevent locking when inserts queue up during long cube runs

Event Timeline

EYener created this task.Jul 20 2020, 10:56 PM

Found the issue. Writing the PID to the file after it has locked seems to release the lock. Looking to see if I can use a write lock to allow the write. If not, we can just not insert the PID which is ok since it's just there for convenience.

Change 615876 had a related patch set uploaded (by Dwisehaupt; owner: Dwisehaupt):
[wikimedia/fundraising/analytics@master] Update to locking code

https://gerrit.wikimedia.org/r/615876

Updated the lock code and pushed it up for review.

Change 615876 merged by Erin Yener:
[wikimedia/fundraising/analytics@master] Update to locking code

https://gerrit.wikimedia.org/r/615876

Dwisehaupt closed this task as Resolved.Jul 24 2020, 4:40 PM
Dwisehaupt moved this task from In Progress to Done on the fundraising-tech-ops board.

@EYener tested this out and pushed the code.