Page MenuHomePhabricator

MenuTagMultiselectWidget removes selected tag if invalid input is entered
Closed, ResolvedPublic2 Estimated Story PointsAug 11 2020

Description

Steps to reproduce:

Expected:

  • The exact behaviour depends on other config, but at the very least the existing tags should not be affected

Actual:

  • The last existing tag is removed, along with the entered text

Event Timeline

ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".

Change 617504 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] OO.ui.MenuSelectWidget: Don't handle keydown if no items are visible

https://gerrit.wikimedia.org/r/617504

Change 617504 merged by jenkins-bot:
[oojs/ui@master] OO.ui.MenuSelectWidget: Don't handle keydown if no items are visible

https://gerrit.wikimedia.org/r/617504

I have not been able to get this working locally.

It may have to wait for a new OOUI release to be tested.

FYI, example of current behaviour:

Change 618983 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.40.1

https://gerrit.wikimedia.org/r/618983

Change 618983 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.40.1

https://gerrit.wikimedia.org/r/618983

I can no longer reproduce the bug in the description.

Otherwise, the CheckUser block form (which uses this widget) behaves the same as before.

Test environment Local vagrant MediaWiki 1.36.0-alpha (ea8438f) CheckUser 2.5 (900fff7).