VE inspector is not positioned correctly near edge of content area when New Vector is enabled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ovasileva
	Jul 21 2020, 3:18 PM

Project Tags

Referenced Files

	F35020136: Screenshot 2022-03-22 at 17.48.26.png
	Mar 22 2022, 5:10 PM

	F34915726: image.png
	Mar 19 2022, 12:54 PM

	F34915729: image.png
	Mar 19 2022, 12:54 PM

	F31943269: Screen Shot 2020-07-19 at 11.50.26 AM.png
	Jul 21 2020, 3:18 PM

Subscribers

Description

Open VisualEditor with New Vector enabled (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Sandbox?veaction=edit&useskin=vector-2022 )
Create a link at the start of a line
Put cursor inside the very start of the link

What happens?:

Arrow pointing at the cursor is off the edge of the popup.

What should have happened instead?:

Arrow pointing at cursor is within the popup

The arrow is in the right place, but the popup isn't being positioned appropriately to match it. I'd speculate that the overlay or the context are getting shifted from their expected position somehow.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Set desktop context / inspector padding to -10px in vector-2022	Esanders	mediawiki/extensions/VisualEditor	master	+9 -1

Customize query in gerrit

Related Objects

Mentioned In: T304202: Inspector not positioned correctly inside dialogs
T303636: Link dialog appears disjointed on narrow screens (with horizontal scrolling)
T250375: QA VE with new header and collapsible sidebar
Mentioned Here: T304202: Inspector not positioned correctly inside dialogs

Event Timeline

ovasileva created this task.Jul 21 2020, 3:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2020, 3:18 PM

ovasileva added a project: Vector 2022.Jul 21 2020, 3:18 PM

ovasileva triaged this task as Medium priority.Jul 24 2020, 2:22 PM

ovasileva edited projects, added: Web-Team-Backlog-Archived (Kanbanana-FY-2020-21); removed: Web-Team-Backlog-Archived.

ovasileva added a subscriber: ppelberg.

ovasileva mentioned this in T250375: QA VE with new header and collapsible sidebar.Jul 24 2020, 3:29 PM

ovasileva moved this task from Incoming to Q1 2020-2021 on the Vector 2022 board.Jul 24 2020, 3:35 PM

Jdlrobson added a project: VisualEditor.Jul 24 2020, 6:57 PM

This is me triaging for Editing, @ovasileva it looks like the Web team engineers are working on this and there is no action for the Editing team. If the Editing team needs to provide support, add the Editing team Request tag.

ovasileva edited projects, added: Web-Team-Backlog-Archived; removed: Web-Team-Backlog-Archived (Kanbanana-FY-2020-21).Jul 28 2020, 6:21 PM

ovasileva moved this task from Incoming to Triaged but Future on the Web-Team-Backlog-Archived board.

The web team is not working on this. We'd need some input from the editing team on what is causing this and how we can help fix it if possible.

ovasileva moved this task from Q1 2020-2021 to For Iteration on the Vector 2022 board.Aug 31 2021, 8:29 PM

Jdlrobson removed a project: Vector 2022.Aug 31 2021, 10:04 PM

Jdlrobson moved this task from Untriaged to Untag on the Web-Team-Backlog-Archived (Tracking) board.Sep 21 2021, 8:42 PM

LGoto removed a project: Web-Team-Backlog-Archived (Tracking).Nov 9 2021, 4:23 PM

• matmarex merged a task: T299070: OOUI popups in VisualEditor misaligned near edge of content area when New Vector is enabled.Jan 27 2022, 5:03 PM

• matmarex added a project: Vector (legacy skin).

• matmarex moved this task from Triaged to To Triage on the VisualEditor board.

• matmarex moved this task from Needs triage to bugs on the Vector (legacy skin) board.

• matmarex added a subscriber: DLynch.

DLynch mentioned this in T303636: Link dialog appears disjointed on narrow screens (with horizontal scrolling).Mar 11 2022, 8:46 PM

Esanders renamed this task from [Bug] Pokey arrow on VE citation and link dialogs not rendering correctly to Inspector callout (small triangle) in VE misaligned near edge of content area when New Vector is enabled.Mar 19 2022, 12:53 PM

Esanders renamed this task from Inspector callout (small triangle) in VE misaligned near edge of content area when New Vector is enabled to VE inspector is not positioned correctly near edge of content area when New Vector is enabled.

Esanders updated the task description. (Show Details)

See also T304202

Change 771991 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Set desktop context / inspector padding to -10px in vector-2022

https://gerrit.wikimedia.org/r/771991

gerritbot added a project: Patch-For-Review.Mar 19 2022, 1:48 PM

Esanders claimed this task.Mar 19 2022, 1:49 PM

Esanders edited projects, added: Editing-team (Kanban Board); removed: Editing-team.

Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.

Esanders moved this task from To Triage to Triaged on the VisualEditor board.

Change 771991 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Set desktop context / inspector padding to -10px in vector-2022

https://gerrit.wikimedia.org/r/771991

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 22 2022, 1:44 AM

DLynch added a project: Editing QA.

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.4; 2022-03-23).Mar 22 2022, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 22 2022, 2:12 AM

Esanders updated the task description. (Show Details)Mar 22 2022, 3:00 PM

All good now:

Screenshot 2022-03-22 at 17.48.26.png (978×404 px, 46 KB)

. See T304202#779752

EAkinloose edited projects, added: Verified; removed: Editing QA.Mar 22 2022, 5:10 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

Jdlrobson added a project: web-team-revisit-later.Mar 22 2022, 8:47 PM

Jdlrobson moved this task from Backlog to Skin layout on the web-team-revisit-later board.

ppelberg closed this task as Resolved.Mar 26 2022, 1:21 AM

VE inspector is not positioned correctly near edge of content area when New Vector is enabledClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

VE inspector is not positioned correctly near edge of content area when New Vector is enabled
Closed, ResolvedPublic
Actions