Page MenuHomePhabricator

Technical: Reconsider logo implementation
Open, Needs TriagePublic

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/585629/52/resources/skins.vector.styles/layout.less @Demian made some popular changes to the logo to simplify its rendering so that it didn't use padding + margin.

According to @nray and @Volker_E they've faced some challenges with the existing CSS and for improved maintenance would like us to pursue the changes proposed in Aron's patch.

We however agreed that this does not and should not need to be coupled with the moving of the personal tools and search in T249363

Aron also provided this patch for simplifying the logo itself (see original bug T256895) which we should definitely consider:
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/608255/8/resources/skins.vector.styles/Logo.less

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2020, 12:04 AM

@nray @Volker_E per our chat Monday it would be helpful to articulate what the challenges are with the status quo while fresh in your memory. Thank you!

Aklapper updated the task description. (Show Details)Jul 24 2020, 8:31 AM
Aklapper added a subscriber: Demian.
nray added a comment.Jul 31 2020, 8:39 PM

@Jdlrobson sorry for the delay on this. I had the following concerns with the status quo:

  • The top margin on the header will make it difficult to implement a sticky header which is on the roadmap for DIP (AFAICT). The top margin will create a space between the header and the viewport e.g.

  • Relatively minor, the top margin on the header makes the calculation for the top position of the sidebar slightly more complex [1]. As an aside and mostly unrelated, we will probably also need to move the sidebar out of the header unless we want that to be sticky as well so this concern may work itself out naturally.

Both of these factors led to me favoring the use of padding instead of margins for the header.

[1] https://github.com/wikimedia/Vector/blob/e0f56960f2aa6d038dc1729ada0e6fbd340aaca1/resources/skins.vector.styles/layout.less#L162

Jdlrobson renamed this task from Technical: Reconsider logo layout rules to Technical: Reconsider logo implementation.Jul 31 2020, 10:20 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Vector.
Jdlrobson updated the task description. (Show Details)