Page MenuHomePhabricator
Create Task
Maniphest T258549

Move logics out of BaseActivity
Closed, DeclinedPublic
Actions

Description

Composition over inheritance

Wanted to fix the GPU overdraw issue for BottomNavigationView (made small progress here) but there's a lot logics inside BaseActivity
I suspect some are redundant and conflicting/ overlapping

Event Timeline

Ericntd created this task.Jul 22 2020, 2:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2020, 2:06 AM
Dbrant closed this task as Declined.Jul 22 2020, 2:35 AM
Dbrant subscribed.

This does not need to be a task. The conversation can continue on the github PR.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits