Page MenuHomePhabricator

Show transfer time once successfully completed
Open, LowestPublic

Description

It would be nice to be able to show the amount of time a transfer took (on non verbose mode) once the transfer has completed successfully.
Ie, current output:

About to transfer /srv/sqldata from db1107.eqiad.wmnet to ['db1084.eqiad.wmnet']:['/srv'] (1235403446655 bytes)
WARNING: Firewall's temporary rule could not be deleted
WARNING: Original size is 1235403446655 but transferred size is 1235403442543 for copy to db1084.eqiad.wmnet
1235403442543 bytes correctly transferred from db1107.eqiad.wmnet to db1084.eqiad.wmnet

It would be nice if we could have something like the following on the default transfer commands (I used: transfer.py --no-checksum --no-encrypt):

Transfer completed in xxxxx seconds

What do you guys think?

Event Timeline

Marostegui moved this task from Triage to GSOC2020 on the DBA board.

Yeah, I think it is a good idea to have transfer time. Thank you!

Note that on the lastest HEAD version, soon to be packaged, the date is show at the start and completion of the backup, like this:

root@cumin1001:~/transferpy$ mkdir ~/test; PYTHONPATH=. python3 transferpy/transfer.py --port=3000 --no-checksum cumin1001.eqiad.wmnet:/home/jynus/transferpy/transferpy/ cumin1001.eqiad.wmnet:/home/jynus/test
2020-07-22 07:49:29  INFO: About to transfer /home/jynus/transferpy/transferpy from cumin1001.eqiad.wmnet to ['cumin1001.eqiad.wmnet']:['/home/jynus/test'] (159274 bytes)
2020-07-22 07:49:36  INFO: 159274 bytes correctly transferred from cumin1001.eqiad.wmnet to cumin1001.eqiad.wmnet

With the timestamps it is easy to know the transfer time. However, it will be less meaningful once the concurrent transfers get merged.

While this is a reasonable feature request, I think it is of a lower priority, and given we are on the last development week (almost) we should focus first on polishing and completing ongoing work.

Yeah, it is something with very low priority (as stated at T258559#6325133). Having both timestamps is indeed useful

Sounds good to me. And yeah, I am currently concentrating on the Gerrit comments and documentation. Thank you!

LSobanski lowered the priority of this task from Low to Lowest.Apr 26 2021, 10:07 AM