Page MenuHomePhabricator
Create Task
Maniphest T258565

Handling failed requests to the federation source Wiki when formatting entities on diff pages
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

BDD
Given My connection to the source Wiki is unavailable
When I load a diff page that involves statements with federated properties
Then the page loads without labels for the properties, just linked PIDs

Related Objects
Search...

Event Timeline

Addshore created this task.Jul 22 2020, 8:35 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2020, 8:35 AM
Addshore added a project: Story.Jul 22 2020, 8:36 AM
Addshore updated the task description. (Show Details)
Addshore added a subtask: T258173: Diff pages throw an exception when the connection to fed props repo is gone.
Addshore set the point value for this task to 5.
Addshore moved this task from Backlog to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.
Addshore moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 4/6 (Hike 2) on the Wikibase - Federated Properties board.Aug 13 2020, 12:38 PM
Addshore edited projects, added Wikibase - Federated Properties (Sprint 4/6 (Hike 2)); removed Wikibase - Federated Properties.
Addshore moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.
Addshore moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 14 2020, 8:30 AM
Addshore moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 17 2020, 12:51 PM

We didnt fill in AC for this ticket, but I believe we met the AC that we dreamed up...
An exception is no longer thrown and the user is shown some diff view..

image.png (626×1 px, 59 KB)

• Samantha_Alipio_WMDE updated the task description. (Show Details)Aug 17 2020, 12:56 PM
• Samantha_Alipio_WMDE moved this task from Product Verification to Done on the Wikibase - Federated Properties (Sprint 4/6 (Hike 2)) board.Aug 17 2020, 12:59 PM
• Samantha_Alipio_WMDE closed this task as Resolved.Aug 19 2020, 1:28 PM
• Samantha_Alipio_WMDE closed subtask T258173: Diff pages throw an exception when the connection to fed props repo is gone as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits