Page MenuHomePhabricator
Create Task
Maniphest T258609

Circular dependency when creating service! GrowthExperimentsConfigurationLoader -> GrowthExperimentsConfigurationLoader
Closed, ResolvedPublic
Actions

Description

Wikimedia\Services\RecursiveServiceDependencyException from line 437 of /vagrant/mediawiki/vendor/wikimedia/services/src/ServiceContainer.php: Recursive service instantiation: Circular dependency when creating service! GrowthExperimentsConfigurationLoader -> GrowthExperimentsConfigurationLoader
#0 /vagrant/mediawiki/vendor/wikimedia/services/src/ServiceContainer.php(416): Wikimedia\Services\ServiceContainer->createService('GrowthExperimen...')
#1 /vagrant/mediawiki/vendor/wikimedia/services/src/ServiceContainer.php(424): Wikimedia\Services\ServiceContainer->getService('GrowthExperimen...')
#2 /vagrant/mediawiki/vendor/wikimedia/object-factory/src/ObjectFactory.php(161): Wikimedia\Services\ServiceContainer->get('GrowthExperimen...')
#3 /vagrant/mediawiki/vendor/wikimedia/object-factory/src/ObjectFactory.php(102): Wikimedia\ObjectFactory::getObjectFromSpec(Array, Array)
#4 /vagrant/mediawiki/includes/HookContainer/HookContainer.php(397): Wikimedia\ObjectFactory->createObject(Array)
#5 /vagrant/mediawiki/includes/HookContainer/HookContainer.php(150): MediaWiki\HookContainer\HookContainer->getHandlers('MessageCache::g...')
#6 /vagrant/mediawiki/includes/HookContainer/HookRunner.php(2592): MediaWiki\HookContainer\HookContainer->run('MessageCache::g...', Array)
#7 /vagrant/mediawiki/includes/cache/MessageCache.php(924): MediaWiki\HookContainer\HookRunner->onMessageCache__get('conversion-ns-2')
#8 /vagrant/mediawiki/includes/language/Message.php(1304): MessageCache->get('conversion-ns-2', true, Object(LanguageZh_hans))
#9 /vagrant/mediawiki/includes/language/Message.php(1002): Message->fetchMessage()
#10 /vagrant/mediawiki/languages/LanguageConverter.php(665): Message->exists()
#11 /vagrant/mediawiki/languages/Language.php(775): LanguageConverter->convertNamespace(-2, 'zh-hans')
#12 /vagrant/mediawiki/languages/Language.php(811): Language->getNamespaceAliases()
#13 /vagrant/mediawiki/languages/Language.php(832): Language->getNamespaceIds()
#14 /vagrant/mediawiki/includes/title/MediaWikiTitleCodec.php(355): Language->getNsIndex('mw')
#15 /vagrant/mediawiki/includes/Title.php(3413): MediaWikiTitleCodec->splitTitleString('mw:Growth/Perso...', 0)
#16 /vagrant/mediawiki/includes/Title.php(392): Title->secureAndSplit('mw:Growth/Perso...', 0)
#17 /vagrant/mediawiki/includes/Title.php(339): Title::newFromTextThrow('mw:Growth/Perso...', 0)
#18 /vagrant/mediawiki/extensions/GrowthExperiments/ServiceWiring.php(29): Title::newFromText('mw:Growth/Perso...')
#19 /vagrant/mediawiki/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer->{closure}(Object(MediaWiki\MediaWikiServices))
#20 /vagrant/mediawiki/vendor/wikimedia/services/src/ServiceContainer.php(416): Wikimedia\Services\ServiceContainer->createService('GrowthExperimen...')
#21 /vagrant/mediawiki/vendor/wikimedia/services/src/ServiceContainer.php(424): Wikimedia\Services\ServiceContainer->getService('GrowthExperimen...')
#22 /vagrant/mediawiki/vendor/wikimedia/object-factory/src/ObjectFactory.php(161): Wikimedia\Services\ServiceContainer->get('GrowthExperimen...')
#23 /vagrant/mediawiki/vendor/wikimedia/object-factory/src/ObjectFactory.php(102): Wikimedia\ObjectFactory::getObjectFromSpec(Array, Array)
#24 /vagrant/mediawiki/includes/HookContainer/HookContainer.php(397): Wikimedia\ObjectFactory->createObject(Array)
#25 /vagrant/mediawiki/includes/HookContainer/HookContainer.php(150): MediaWiki\HookContainer\HookContainer->getHandlers('MessageCache::g...')
#26 /vagrant/mediawiki/includes/HookContainer/HookRunner.php(2592): MediaWiki\HookContainer\HookContainer->run('MessageCache::g...', Array)
#27 /vagrant/mediawiki/includes/cache/MessageCache.php(924): MediaWiki\HookContainer\HookRunner->onMessageCache__get('seconds-abbrev')
#28 /vagrant/mediawiki/includes/language/Message.php(1304): MessageCache->get('seconds-abbrev', true, Object(LanguageEn))
#29 /vagrant/mediawiki/includes/language/Message.php(862): Message->fetchMessage()
#30 /vagrant/mediawiki/includes/language/Message.php(954): Message->toString('text')
#31 /vagrant/mediawiki/languages/Language.php(4639): Message->text()
#32 /vagrant/mediawiki/maintenance/update.php(208): Language->formatTimePeriod(0.84515190124512)
#33 /vagrant/mediawiki/maintenance/doMaintenance.php(107): UpdateMediaWiki->execute()
#34 /vagrant/mediawiki/maintenance/update.php(255): require_once('/vagrant/mediaw...')
#35 /var/www/w/MWScript.php(98): require_once('/vagrant/mediaw...')
#36 {main}

Seen on my local setup. Seems to be related to LanguageConverter somehow; of the wikis set up by the Vagrant langwiki role, it only affects zhwiki and zhwikivoyagewiki.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Improve I0b10612mediawiki/extensions/GrowthExperimentsmaster+94 -19
Fast and ugly fix for T258609mediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.2+22 -10
Fast and ugly fix for T258609mediawiki/extensions/GrowthExperimentsmaster+22 -10
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Jul 22 2020, 4:09 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 22 2020, 4:09 PM
Restricted Application added subscribers: Stang, Aklapper. · View Herald Transcript
Tgr added a comment.Jul 22 2020, 4:36 PM

Beta srwiki (the only Growth wiki which uses LanguageConverter) is not affected. Either the issue is specific to vagrant or specific to the Chinese wikis' (significantly different) language conversion configuration.

brennen triaged this task as Unbreak Now! priority.Jul 30 2020, 7:19 PM
brennen added projects: Wikimedia-production-error, User-brennen.
brennen subscribed.

This (or something very similar) exploded when 1.36.0-wmf.2 moved to all wikis a few minutes ago.

brennen added a parent task: T257970: 1.36.0-wmf.2 deployment blockers.Jul 30 2020, 7:19 PM
greg subscribed.Jul 30 2020, 7:23 PM

See: https://logstash.wikimedia.org/goto/713e8d611f054675a36d71151881091f

Tgr claimed this task.Jul 30 2020, 7:26 PM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Tgr moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• Agusbou2015 subscribed.Jul 30 2020, 7:27 PM
Tgr added a comment.Jul 30 2020, 7:29 PM
In T258609#6326917, @Tgr wrote:

Beta srwiki (the only Growth wiki which uses LanguageConverter) is not affected.

But production srwiki is, apparently. Do their language settings differ somehow?

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Jul 30 2020, 7:36 PM
RhinosF1 subscribed.Jul 30 2020, 7:55 PM
Tgr added a comment.Jul 30 2020, 7:57 PM

Probably the immediate trigger was rEGREb2bc51779bf1: HomepageHooks: Convert to HookHandler which converted a bunch of hooks to the new system (meaning the dependencies of all hooks are fetched when any hook is invoked). Some subsequent patches build on it so it's not trivial to revert but we can revert together with followups if we are in a rush.

So, various hooks (including some very common ones like MessageCache::get or UserGetDefaultOptions) cause HomepageHooks to be instantiated, with GrowthExperimentsConfigurationLoader as a service dependency. The configuration loader tries to create a Title (from which the configuration will be loaded); that involves a namespace check, which in turn involves LanguageConverter::convertNamespace, which is customizable via system messages, so MessageCache::get is invoked again. The triggering hook varies, but otherwise it seems to be the process for all logged errors.

gerritbot added a comment.Jul 30 2020, 8:13 PM

Change 617534 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fast and ugly fix for T258609

https://gerrit.wikimedia.org/r/617534

gerritbot added a project: Patch-For-Review.Jul 30 2020, 8:13 PM
gerritbot added a comment.Jul 30 2020, 8:49 PM

Change 617437 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.2] Fast and ugly fix for T258609

https://gerrit.wikimedia.org/r/617437

gerritbot added a comment.Jul 30 2020, 9:14 PM

Change 617534 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fast and ugly fix for T258609

https://gerrit.wikimedia.org/r/617534

gerritbot added a comment.Jul 30 2020, 9:31 PM

Change 617437 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.2] Fast and ugly fix for T258609

https://gerrit.wikimedia.org/r/617437

Stashbot added a comment.Jul 30 2020, 9:40 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-30T21:40:53Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.2/extensions/GrowthExperiments/: T258609 (duration: 01m 06s)

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 30 2020, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2020, 10:10 PM
gerritbot added a comment.Jul 30 2020, 10:21 PM

Change 617552 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Improve I0b10612

https://gerrit.wikimedia.org/r/617552

gerritbot added a project: Patch-For-Review.Jul 30 2020, 10:21 PM
Tgr moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jul 30 2020, 10:24 PM
brennen mentioned this in T257970: 1.36.0-wmf.2 deployment blockers.Jul 30 2020, 10:32 PM
brennen removed a parent task: T257970: 1.36.0-wmf.2 deployment blockers.Jul 30 2020, 10:36 PM
Shizhao added a project: Chinese-Sites.Jul 31 2020, 2:37 AM
Shizhao moved this task from Backlog to Extensions/Skins on the Chinese-Sites board.Jul 31 2020, 2:42 AM
VulpesVulpes825 removed a project: Chinese-Sites.Aug 2 2020, 7:10 AM
VulpesVulpes825 subscribed.

Remove Chinese-Sites as the extension has not been deployed to any zh projects.

VulpesVulpes825 unsubscribed.Aug 2 2020, 7:10 AM
Tgr closed this task as Resolved.Aug 3 2020, 3:23 PM

There is a code quality improvement patch waiting for review, but the actual bug was fixed, so let's close this.

gerritbot added a comment.Aug 17 2020, 12:11 PM

Change 617552 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Improve I0b10612

https://gerrit.wikimedia.org/r/617552

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.5; 2020-08-18); removed MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Aug 17 2020, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 17 2020, 1:10 PM
Stang unsubscribed.Nov 13 2021, 8:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits