Page MenuHomePhabricator
Create Task
Maniphest T258622

Poor display of media on Special:NewFiles
Closed, ResolvedPublicBUG REPORT
Actions

Description

The VideoJS player is completely unadapted for small preview sizes. The video list can be corrected by my patch T258584#6326751, but audio it is necessary to fix it in a separate stream.

Test link: https://commons.wikimedia.beta.wmflabs.org/wiki/Special:NewFiles?user=&mediatype[]=AUDIO

AudioVideo
image.png (828×1 px, 180 KB)
image.png (790×1 px, 820 KB)
Audio enable button is outside the blockPlay button not on the same line

Details

SubjectRepoBranchLines +/-
Oops, forgot a space! Fixing CSS selector.mediawiki/extensions/TimedMediaHandlermaster+1 -1
Overriding audioplayer width within galleryboxesmediawiki/extensions/TimedMediaHandlermaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Iniquity created this task.Jul 22 2020, 5:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2020, 5:38 PM
Iniquity moved this task from Backlog to Bugs on the VideoJS player board.Jul 22 2020, 5:39 PM
Iniquity updated the task description. (Show Details)
Iniquity mentioned this in T248418: Roll out videojs as the only video/audio player on all Wikimedia wikis.Aug 3 2020, 5:21 PM
Aklapper updated the task description. (Show Details)Oct 18 2020, 12:06 AM
kaldari added subscribers: • brion, kaldari.EditedDec 7 2020, 7:51 PM

Note that this is a cosmetic issue as the buttons are still clickable and functional.

gerritbot added a comment.Dec 7 2020, 8:33 PM

Change 646827 had a related patch set uploaded (by Kaldari; owner: Kaldari):
[mediawiki/extensions/TimedMediaHandler@master] Overriding audiopleyer width within galleryboxes

https://gerrit.wikimedia.org/r/646827

gerritbot added a project: Patch-For-Review.Dec 7 2020, 8:33 PM
Jdforrester-WMF closed this task as Resolved.Dec 9 2020, 5:18 PM
Jdforrester-WMF assigned this task to kaldari.
Jdforrester-WMF subscribed.

Thanks!

gerritbot added a comment.Dec 9 2020, 5:41 PM

Change 646827 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Overriding audioplayer width within galleryboxes

https://gerrit.wikimedia.org/r/646827

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 9 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 9 2020, 6:10 PM
kaldari reopened this task as Open.Dec 25 2020, 10:31 PM

Oops, my CSS is missing a space!

gerritbot added a comment.Dec 25 2020, 10:43 PM

Change 651947 had a related patch set uploaded (by Kaldari; owner: Kaldari):
[mediawiki/extensions/TimedMediaHandler@master] Oops, forgot a space! Fixing CSS selector.

https://gerrit.wikimedia.org/r/651947

gerritbot added a project: Patch-For-Review.Dec 25 2020, 10:43 PM
gerritbot added a comment.Dec 25 2020, 11:11 PM

Change 651947 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Oops, forgot a space! Fixing CSS selector.

https://gerrit.wikimedia.org/r/651947

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.22; 2020-12-15).Dec 26 2020, 12:04 AM
kaldari closed this task as Resolved.Dec 26 2020, 12:06 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL