jsonschema-tools should have option to materialize schemas with default max/min validation for e.g. max long, max double, etc.
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Nuria
	Jul 22 2020, 10:07 PM

Description

JSON will allow serialization of numbers outside of the range of their binary counterparts, e.g. max 64 bit long. jsonschema-tools should have a configuration option to automatically materialize schemas with number fields that don't already have maximum and/or minimum validation rules to e.g. max long and max double.

Details

Subject	Repo	Branch	Lines +/-
Rematerialize all schemas wiith enforced numeric bounds	schemas/event/primary	master	+3 K -2 K
Temporarily disable numeric bounds enforcement	schemas/event/primary	master	+1 -1
Temporarily disable numeric bounds enforcement	schemas/event/secondary	master	+3 -0
Temporarily disable numeric bounds enforcement	schemas/event/primary	master	+3 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	• Gilles	T254606 Invalid navigation timing events
Resolved	• fdans	T258659 jsonschema-tools should have option to materialize schemas with default max/min validation for e.g. max long, max double, etc.
Resolved	Ottomata	T273069 Rematerialize all event schemas with enforceNumericBounds

Event Timeline

• Nuria created this task.Jul 22 2020, 10:07 PM

• Nuria reassigned this task from • Gilles to • fdans.Jul 24 2020, 2:43 PM

• Nuria added a project: Analytics-Kanban.

• Nuria added a subscriber: • Gilles.

This comment was removed by • Nuria.

• Nuria updated the task description. (Show Details)Jul 24 2020, 6:57 PM

Krinkle removed a project: Performance-Team.Jul 27 2020, 8:01 PM

• fdans triaged this task as High priority.Aug 3 2020, 4:27 PM

• fdans moved this task from Incoming to Event Platform on the Analytics board.

Ottomata renamed this task from Validation rules on eventgate should take max int values into account in order to validate data for an schema to jsonschema-tools should have option to materialize schemas with default max/min validation for e.g. max long, max double, etc..Aug 3 2020, 4:30 PM

Ottomata updated the task description. (Show Details)

Ottomata moved this task from Next Up to In Progress on the Analytics-Kanban board.Aug 17 2020, 3:45 PM

PR created in Github: https://github.com/wikimedia/jsonschema-tools/pull/16

• fdans moved this task from In Progress to In Code Review on the Analytics-Kanban board.Aug 24 2020, 9:06 AM

Change 624684 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[schemas/event/primary@master] Temporarily disable numeric bounds enforcement

https://gerrit.wikimedia.org/r/624684

Change 624685 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[schemas/event/secondary@master] Temporarily disable numeric bounds enforcement

https://gerrit.wikimedia.org/r/624685

Change 624684 merged by Ottomata:
[schemas/event/primary@master] Temporarily disable numeric bounds enforcement

https://gerrit.wikimedia.org/r/624684

Change 624685 merged by Ottomata:
[schemas/event/secondary@master] Temporarily disable numeric bounds enforcement

https://gerrit.wikimedia.org/r/624685

Making note so @fdans can work on adding bounds to schemas that need it when he is back

Change 624803 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[schemas/event/primary@master] Temporarily disable numeric bounds enforcement

https://gerrit.wikimedia.org/r/624803

Change 624803 abandoned by Ottomata:
[schemas/event/primary@master] Temporarily disable numeric bounds enforcement

Reason:

https://gerrit.wikimedia.org/r/624803

FYI had to add a few of fixes:

I shoulda caught those in review!

• fdans moved this task from In Code Review to Done on the Analytics-Kanban board.Oct 26 2020, 4:23 PM

• fdans closed this task as Resolved.Nov 16 2020, 3:51 PM

Ottomata mentioned this in T273069: Rematerialize all event schemas with enforceNumericBounds.Jan 27 2021, 3:47 PM

• fdans closed subtask T273069: Rematerialize all event schemas with enforceNumericBounds as Resolved.Mar 18 2021, 4:01 PM

Change 703249 had a related patch set uploaded (by Ottomata; author: Ottomata):

[schemas/event/primary@master] Rematerialize all schemas wiith enforced numeric bounds

https://gerrit.wikimedia.org/r/703249

Change 703249 merged by jenkins-bot: