| Krinkle | |
| Jul 22 2020, 10:49 PM |
| F31945108: Screenshot_2020-07-22 ResourceLoader - Grafana.png | |
| Jul 23 2020, 12:49 AM |
| F31945034: export.png | |
| Jul 22 2020, 10:49 PM |
| F31945032: Screenshot 2020-07-22 at 23.46.21.png | |
| Jul 22 2020, 10:49 PM |
https://performance.wikimedia.org/arclamp/svgs/daily/2020-07-21.excimer.load.svgz
This shows a huge block that wasn't there before:
Related code is from InstallerExtensionSelector.php, which was introduced last week and seems to be scanning unlimited and without batching or caching and then parsing extension.json files. This is presumably not meant to be enabled in production :)
This was introduced in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/46eabe275c923ca7827435a36d6576150cea8899
I briefly discussed this with Krinkle on IRC that a full revert makes sense, because of the performance degradation and the other problems I noticed while reviewing the patch that I'll explain in a bit.
(Correction: The regression takes up 20% of today's latency; which means, 100/80=, it is a 25% latency regression.)
Change 615584 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] Revert "Add a new type of database to the installer from extension"
Change 615439 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@wmf/1.36.0-wmf.1] Revert "Add a new type of database to the installer from extension"
Change 615440 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@wmf/1.35.0-wmf.41] Revert "Add a new type of database to the installer from extension"
Change 615584 merged by jenkins-bot:
[mediawiki/core@master] Revert "Add a new type of database to the installer from extension"
Change 615439 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.1] Revert "Add a new type of database to the installer from extension"
Change 615440 merged by jenkins-bot:
[mediawiki/core@wmf/1.35.0-wmf.41] Revert "Add a new type of database to the installer from extension"
Mentioned in SAL (#wikimedia-operations) [2020-07-23T00:16:56Z] <legoktm@deploy1001> Synchronized php-1.36.0-wmf.1/includes/: T258664: Revert "Add a new type of database to the installer from extension" (duration: 01m 09s)
Mentioned in SAL (#wikimedia-operations) [2020-07-23T00:22:47Z] <legoktm@deploy1001> Synchronized php-1.35.0-wmf.41/includes/libs/rdbms/database/Database.php: T258664: Revert "Add a new type of database to the installer from extension" (duration: 01m 05s)
Mentioned in SAL (#wikimedia-operations) [2020-07-23T00:24:13Z] <legoktm@deploy1001> Synchronized php-1.35.0-wmf.41/includes/: T258664: Revert "Add a new type of database to the installer from extension" (2/2) (duration: 01m 08s)
Change 615441 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@REL1_35] Revert "Add a new type of database to the installer from extension"
Change 615441 merged by jenkins-bot:
[mediawiki/core@REL1_35] Revert "Add a new type of database to the installer from extension"
@CCicalese_WMF let's review with the rest of the team next week when you're back to figure out how the regression got all the way out.
