Page MenuHomePhabricator

Discourage “traditional” / ANSI-89 JOINs (in WHERE instead of JOIN) in IDatabase documentation
Closed, ResolvedPublic

Description

The IDatabase::select documentation suggests to put simple JOINs directly in the WHERE conditions. (This StackOverflow answer describes this as “traditional” / ANSI-89 syntax, with JOIN being ANSI-92 syntax.) @jcrespo says these joins should not be used, and I see no reason not to believe him, so let’s fix the documentation so it doesn’t encourage antipatterns. (See parent task for some details.)

Details

Event Timeline

Change 615709 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/core@master] rdbms: Strongly discourage simple joins in $conds

https://gerrit.wikimedia.org/r/615709

Change 615709 merged by jenkins-bot:
[mediawiki/core@master] rdbms: Strongly discourage simple joins in $conds

https://gerrit.wikimedia.org/r/615709