Page MenuHomePhabricator
Create Task
Maniphest T258695

Investigate why ClosedWikiProvider doesn't work
Closed, ResolvedPublic
Actions

Description

In T222117, we added ClosedWikiProvider, which allows stewards/sysadmins/etc to create accounts for themselves at closed wikis and disallows the rest autocreations. However, various users, including myself using my staff account, were able to autocreate accounts for them.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ClosedWikiProvider: Use testUserForCreation rather than testForAuthenticationoperations/mediawiki-configmaster+8 -8
Log ClosedWikiProvider's start with info leveloperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Jul 23 2020, 11:44 AM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJul 23 2020, 11:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jul 23 2020, 11:46 AM

Change 615713 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Log ClosedWikiProvider's start with info level

https://gerrit.wikimedia.org/r/615713

gerritbot added a project: Patch-For-Review.Jul 23 2020, 11:46 AM
gerritbot added a comment.Jul 23 2020, 11:48 AM

Change 615713 merged by jenkins-bot:
[operations/mediawiki-config@master] Log ClosedWikiProvider's start with info level

https://gerrit.wikimedia.org/r/615713

Stashbot added a comment.Jul 23 2020, 11:49 AM

Mentioned in SAL (#wikimedia-operations) [2020-07-23T11:49:56Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: 745ff20f53e4914cf6e1717c963419e74b68e693: Log ClosedWikiProviders start with info level (T258695) (duration: 01m 05s)

Maintenance_bot removed a project: Patch-For-Review.Jul 23 2020, 12:10 PM
gerritbot added a comment.Jul 23 2020, 12:23 PM

Change 615723 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] ClosedWikiProvider: Use testUserForCreation rather than testForAuthentication

https://gerrit.wikimedia.org/r/615723

gerritbot added a project: Patch-For-Review.Jul 23 2020, 12:23 PM
Urbanecm triaged this task as Low priority.Jul 23 2020, 12:27 PM
Urbanecm moved this task from Backlog to Waiting on review on the User-Urbanecm board.
Urbanecm moved this task from Backlog to To deploy on the Wikimedia-Site-requests board.
Urbanecm updated the task description. (Show Details)
gerritbot added a comment.Aug 19 2020, 6:38 PM

Change 615723 merged by jenkins-bot:
[operations/mediawiki-config@master] ClosedWikiProvider: Use testUserForCreation rather than testForAuthentication

https://gerrit.wikimedia.org/r/615723

Stashbot added a comment.Aug 19 2020, 6:45 PM

Mentioned in SAL (#wikimedia-operations) [2020-08-19T18:45:21Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: 83b34e1bd1ed804a70f67e089580e082f89e2a0f: ClosedWikiProvider: Use testUserForCreation rather than testForAuthentication (T258695) (duration: 01m 04s)

Urbanecm closed this task as Resolved.Aug 19 2020, 6:47 PM

This should be fixed now, tested with my WMF account, which has no special global privileges.

Zabe removed a project: Patch-For-Review.Oct 30 2021, 7:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits