In service.yaml each description looks something like:
description: Main MediaWiki application server cluster, appservers.svc.%{::site}.wmnetHowever the %{::site} gets expanded on the active Icinga host, and is always eqiad. This is confusing.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| service: Replace svc.%{::site} with discovery | operations/puppet | production | +59 -59 |
Event Timeline
Comment Actions
that description is used in a comment in pybal, where the $::site is evaluated correctly.
The problem here is that it was reused to make the icinga alerts unique AIUI. but we can also drop them of course, I'm just saying this is not just a mistake :)
Comment Actions
Is this still relevant? I think we moved all LVS alerts off of icinga by now. But yeah no objection apart from what I stated above.
Comment Actions
No, it's not relevant to icinga so much any more (and it's going to be less and less). It's still an interesting informational thing though and the replacement is easy enough that I am just gonna give it a try.
Comment Actions
Change 936062 had a related patch set uploaded (by Alexandros Kosiaris; author: Alexandros Kosiaris):
[operations/puppet@production] service: Replace svc.%{::site} with discovery
Comment Actions
Change 936062 merged by Alexandros Kosiaris:
[operations/puppet@production] service: Replace svc.%{::site} with discovery
Comment Actions
PCC at https://puppet-compiler.wmflabs.org/output/936062/42341/ says 0 diff for alert hosts, lvs hosts see a comment change in configuration and there arguably the .discovery.wmnet approach is better anyway informationally. The alerting part of this task doesn't apply anymore anyway, I am gonna resolve this.