Page MenuHomePhabricator
Create Task
Maniphest T258701

Alignment of buttons in grouped notification
Closed, ResolvedPublic
Actions

Description

image.png (238×490 px, 18 KB)

The "Collapse" button is well below the other two buttons on the same line.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make MenuItemWidgets inherit from ButtonOptionWidgetsmediawiki/extensions/Echomaster+13 -8
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 23 2020, 12:45 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 23 2020, 12:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders claimed this task.Jul 23 2020, 1:23 PM
gerritbot added a comment.Jul 23 2020, 2:27 PM

Change 615752 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Make MenuItemWidgets inherit from ButtonOptionWidgets

https://gerrit.wikimedia.org/r/615752

gerritbot added a project: Patch-For-Review.Jul 23 2020, 2:27 PM
gerritbot added a comment.Jul 23 2020, 11:42 PM

Change 615752 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Make MenuItemWidgets inherit from ButtonOptionWidgets

https://gerrit.wikimedia.org/r/615752

Maintenance_bot removed a project: Patch-For-Review.Jul 24 2020, 12:11 AM
Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jul 24 2020, 12:25 AM
Catrope moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova closed this task as Resolved.Jul 28 2020, 1:21 AM
Etonkovidova subscribed.

Comparing

testwiki wmf.1betalabs
Screen Shot 2020-07-27 at 5.57.09 PM.png (220×705 px, 50 KB)
Screen Shot 2020-07-27 at 5.56.12 PM.png (142×587 px, 28 KB)

In other languages the labels might overlap the timestamp - filed as a minor bug T258990: [minor] "Stop watching the topic" label overflows the timestamp

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits