Page MenuHomePhabricator
Create Task
Maniphest T258703

Inconsistent hover states in notification
Closed, ResolvedPublic
Actions

Description

If I hover on "Main Page" the opacity increases:

image.png (113×486 px, 12 KB)

If I hover on "Stop watching..." the opacity increases and the background is set to white
image.png (111×486 px, 12 KB)

If I hover on "Collapse/Expand" the background is set to a darker grey (and the opacity was already high):
image.png (108×483 px, 12 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make MenuItemWidgets inherit from ButtonOptionWidgetsmediawiki/extensions/Echomaster+13 -8
Remove light background from dynamic-action hover statemediawiki/extensions/Echomaster+0 -4
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 23 2020, 12:50 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 23 2020, 12:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders added a comment.Jul 23 2020, 1:01 PM
This comment was removed by Esanders.
Esanders claimed this task.Jul 23 2020, 1:23 PM
gerritbot added a comment.Jul 23 2020, 2:27 PM

Change 615748 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Remove light background from dynamic-action hover state

https://gerrit.wikimedia.org/r/615748

gerritbot added a project: Patch-For-Review.Jul 23 2020, 2:27 PM

Change 615752 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Make MenuItemWidgets inherit from ButtonOptionWidgets

https://gerrit.wikimedia.org/r/615752

gerritbot added a comment.Jul 23 2020, 11:39 PM

Change 615748 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove light background from dynamic-action hover state

https://gerrit.wikimedia.org/r/615748

gerritbot added a comment.Jul 23 2020, 11:42 PM

Change 615752 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Make MenuItemWidgets inherit from ButtonOptionWidgets

https://gerrit.wikimedia.org/r/615752

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 24 2020, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2020, 12:11 AM
Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jul 24 2020, 12:25 AM
Catrope moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova closed this task as Resolved.Jul 29 2020, 9:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits