Page MenuHomePhabricator
Create Task
Maniphest T258705

Focusing a notification draws an odd outline
Closed, ResolvedPublic
Actions

Assigned To
Esanders
Authored By
Esanders
Jul 23 2020, 1:18 PM
Tags
Referenced Files
F31953414: Screen Shot 2020-07-29 at 11.30.30 AM.png
Jul 29 2020, 6:31 PM
F31953409: Screen Shot 2020-07-29 at 11.27.47 AM.png
Jul 29 2020, 6:31 PM
F31945912: image.png
Jul 23 2020, 1:46 PM
F31945873: image.png
Jul 23 2020, 1:18 PM
Subscribers
Aklapper
Esanders
Etonkovidova
Tokens
"Like" token, awarded by Volker_E.

Description

image.png (158×523 px, 18 KB)

image.png (93×491 px, 8 KB)

Details

SubjectRepoBranchLines +/-
Make NotificationItemWidget an <a> tag to fix focus issuesmediawiki/extensions/Echomaster+22 -13
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 23 2020, 1:18 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 23 2020, 1:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders claimed this task.Jul 23 2020, 1:23 PM
Esanders updated the task description. (Show Details)Jul 23 2020, 1:46 PM
Esanders added a comment.Jul 23 2020, 1:56 PM

Related: anywhere outside these outlines is not clickable and does not get cursor:pointer

gerritbot added a comment.Jul 23 2020, 2:27 PM

Change 615750 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Make NotificationItemWidget an <a> tag to fix focus issues

https://gerrit.wikimedia.org/r/615750

gerritbot added a project: Patch-For-Review.Jul 23 2020, 2:27 PM
gerritbot added a comment.Jul 23 2020, 11:42 PM

Change 615750 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Make NotificationItemWidget an <a> tag to fix focus issues

https://gerrit.wikimedia.org/r/615750

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 24 2020, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 24 2020, 12:11 AM
Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jul 24 2020, 12:26 AM
Catrope moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova closed this task as Resolved.Jul 29 2020, 6:31 PM
Etonkovidova subscribed.

Checked in testwiki wmf.2 - the focus is much more consistent not only in shape (the odd outline is gone), but also that it provide additional focus on notifications that don't have a primary link before.

Screen Shot 2020-07-29 at 11.27.47 AM.png (263×518 px, 34 KB)

The focus for "Mark as read" button was not provided before:

Screen Shot 2020-07-29 at 11.30.30 AM.png (153×519 px, 21 KB)

Volker_E awarded a token.Jul 29 2020, 11:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL