Page MenuHomePhabricator

Focusing a notification draws an odd outline
Closed, ResolvedPublic

Description


Event Timeline

Esanders created this task.Jul 23 2020, 1:18 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 23 2020, 1:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Esanders claimed this task.Jul 23 2020, 1:23 PM
Esanders updated the task description. (Show Details)Jul 23 2020, 1:46 PM

Related: anywhere outside these outlines is not clickable and does not get cursor:pointer

Change 615750 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Make NotificationItemWidget an <a> tag to fix focus issues

https://gerrit.wikimedia.org/r/615750

Change 615750 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Make NotificationItemWidget an <a> tag to fix focus issues

https://gerrit.wikimedia.org/r/615750

Catrope moved this task from Incoming to QA on the Growth-Team (Current Sprint) board.
Etonkovidova closed this task as Resolved.Jul 29 2020, 6:31 PM
Etonkovidova added a subscriber: Etonkovidova.

Checked in testwiki wmf.2 - the focus is much more consistent not only in shape (the odd outline is gone), but also that it provide additional focus on notifications that don't have a primary link before.

The focus for "Mark as read" button was not provided before: