Page MenuHomePhabricator
Create Task
Maniphest T258728

MobileFrontend browser test failing: User:<username> "before all" hook – Can't call setValue on element with selector "#wpName1" because element wasn't found
Closed, ResolvedPublic
Actions

Description

Example: https://integration.wikimedia.org/ci/job/quibble-vendor-selenium-docker/25121/console

16:24:24 ------------------------------------------------------------------
16:24:24 [Chrome 73.0.3683.75 linux #0-1] Spec: /workspace/src/extensions/MobileFrontend/tests/selenium/specs/user_page.js
16:24:24 [Chrome 73.0.3683.75 linux #0-1] Running: Chrome (v73.0.3683.75) on linux
16:24:24 [Chrome 73.0.3683.75 linux #0-1] Session ID: d67b6295-f652-47d6-b460-754531a1713c
16:24:24 [Chrome 73.0.3683.75 linux #0-1]
16:24:24 [Chrome 73.0.3683.75 linux #0-1] User:<username>
16:24:24 [Chrome 73.0.3683.75 linux #0-1]    ✖ "before all" hook
16:24:24 [Chrome 73.0.3683.75 linux #0-1]
16:24:24 [Chrome 73.0.3683.75 linux #0-1] 1 failing (12.9s)
16:24:24 [Chrome 73.0.3683.75 linux #0-1]
16:24:24 [Chrome 73.0.3683.75 linux #0-1] 1) User:<username> "before all" hook
16:24:24 [Chrome 73.0.3683.75 linux #0-1] Can't call setValue on element with selector "#wpName1" because element wasn't found
16:24:24 [Chrome 73.0.3683.75 linux #0-1] Error: Can't call setValue on element with selector "#wpName1" because element wasn't found
16:24:24 [Chrome 73.0.3683.75 linux #0-1]     at LoginPage.login (/workspace/src/extensions/MobileFrontend/node_modules/wdio-mediawiki/LoginPage.js:15:17)
16:24:24 [Chrome 73.0.3683.75 linux #0-1]     at login (/workspace/src/extensions/MobileFrontend/tests/selenium/specs/user_page.js:22:18)
16:24:24 [Chrome 73.0.3683.75 linux #0-1]     at Context.before (/workspace/src/extensions/MobileFrontend/tests/selenium/specs/user_page.js:38:3)

Details

SubjectRepoBranchLines +/-
Run jobs inside browser.callmediawiki/extensions/MobileFrontendmaster+1 -1
Revert "Selenium: Update to WebdriverIO v6"mediawiki/extensions/MobileFrontendmaster+663 -1 K
Hack: Selenium tests should visit user login pagemediawiki/extensions/MobileFrontendmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jul 23 2020, 4:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2020, 4:40 PM
Lucas_Werkmeister_WMDE added subscribers: Vidhi-Mody, zeljkofilipin.EditedJul 23 2020, 4:42 PM

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/615711 had a successful test build on 15:50 UTC today and then the first failure on 16:06 UTC today. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/615682 was merged right between those times if I’m not mistaken, so that seems like a likely culprit.

Ladsgroup subscribed.Jul 23 2020, 4:45 PM
Vidhi-Mody added a comment.Jul 23 2020, 5:20 PM

PS1 of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/615682 failed with the same error
(See: https://integration.wikimedia.org/ci/job/quibble-vendor-selenium-docker/25010/console#console-section-8)

on running recheck, the same patch seemed to be working fine
(See: https://integration.wikimedia.org/ci/job/quibble-vendor-selenium-docker/25065/consoleFull#console-section-8)

Jdlrobson added projects: Quality-and-Test-Engineering-Team, Web-Team-Backlog (Tracking).Jul 23 2020, 7:08 PM
Jdlrobson subscribed.

Adding QTE since there are some changes being made relating to T256977 which are likely to be the culprit (no other changes to MobileFrontend that I'm aware of)

Jdlrobson added a comment.EditedJul 23 2020, 7:38 PM

This is blocking all merges on Minerva now so has potential to become UBN:
e.g https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/615813
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php72-docker/69138/console

Ladsgroup added a comment.Jul 23 2020, 7:42 PM

For wikibase it fails for every other run. Quite annoying.

xSavitar subscribed.Jul 23 2020, 7:54 PM
Jdlrobson mentioned this in T258096: Regression: Nested references do not open if user clicks on [ or ] (which are wrapped in span).Jul 23 2020, 8:19 PM
Reedy renamed this task from MobileFrontend browser test failing in Wikibase CI: User:<username> "before all" hook – Can't call setValue on element with selector "#wpName1" because element wasn't found to MobileFrontend browser test failing: User:<username> "before all" hook – Can't call setValue on element with selector "#wpName1" because element wasn't found.Jul 23 2020, 10:44 PM
Reedy triaged this task as High priority.
Reedy edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error.
Reedy subscribed.

Not just Wikibase

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/615314/ and https://integration.wikimedia.org/ci/job/wmf-quibble-selenium-php72-docker/52623/console

gerritbot added a comment.Jul 23 2020, 11:27 PM

Change 615880 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Selenium tests should visit user login page

https://gerrit.wikimedia.org/r/615880

gerritbot added a project: Patch-For-Review.Jul 23 2020, 11:27 PM
Jdlrobson added a comment.Jul 23 2020, 11:37 PM

Annoyingly there was no video asset of the failure, so I couldn't actually tell what the problem is here - but luckily could replicate it locally. I think this should be ficed in wdio-mediawiki/LoginPage in core but for now this should suffice to unblock people.

Jdlrobson moved this task from Backlog to team:other on the MobileFrontend board.Jul 24 2020, 2:29 AM
Jdlrobson moved this task from team:other to Tracking on the MobileFrontend board.Jul 24 2020, 2:40 AM
Jdlrobson edited projects, added MobileFrontend (Tracking); removed MobileFrontend.
Ostrzyciel subscribed.Jul 24 2020, 8:16 AM
This comment was removed by Ostrzyciel.
• Tonina_Zhelyazkova_WMDE subscribed.Jul 24 2020, 8:48 AM
zeljkofilipin claimed this task.Jul 24 2020, 9:52 AM
zeljkofilipin added projects: User-zeljkofilipin, User-Vidhi-Mody.
zeljkofilipin moved this task from Inbox to Test engineering on the Quality-and-Test-Engineering-Team board.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
Ladsgroup raised the priority of this task from High to Unbreak Now!.Jul 24 2020, 1:53 PM

This patch failed three consecutive times so far. I can't get much done with this.

gerritbot added a comment.Jul 24 2020, 1:55 PM

Change 616031 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/MobileFrontend@master] Revert "Selenium: Update to WebdriverIO v6"

https://gerrit.wikimedia.org/r/616031

• toan subscribed.Jul 24 2020, 1:56 PM
zeljkofilipin added a comment.EditedJul 24 2020, 2:00 PM
In T258728#6333041, @Ladsgroup wrote:

This patch failed three consecutive times so far. I can't get much done with this.

Apologies for all the trouble. I've reverted 616031 (Selenium: Update to WebdriverIO v6). I'll test if it fixes things as soon as it merges. We'll be much more careful the next time we attempt the update.

@Vidhi-Mody has already updated many repositories (T247844), we didn't have a problem like this so far.

Jdlrobson added a comment.EditedJul 24 2020, 2:17 PM

There was no need to revert https://gerrit.wikimedia.org/r/c/615880 fixes the issue without the revert.

gerritbot added a comment.Jul 24 2020, 2:21 PM

Change 615880 abandoned by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Selenium tests should visit user login page

Reason:
The patch was reverted (but when it is eventually restored it will probably want to include this change)

https://gerrit.wikimedia.org/r/615880

RhinosF1 subscribed.Jul 24 2020, 2:24 PM
gerritbot added a comment.Jul 24 2020, 2:24 PM

Change 615880 restored by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Selenium tests should visit user login page

https://gerrit.wikimedia.org/r/615880

gerritbot added a comment.Jul 24 2020, 2:44 PM

Change 616112 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Run jobs inside browser.call

https://gerrit.wikimedia.org/r/616112

gerritbot added a comment.Jul 24 2020, 2:45 PM

Change 615880 abandoned by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Hack: Selenium tests should visit user login page

Reason:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/ /616112 is a more logical easy to follow solution

https://gerrit.wikimedia.org/r/615880

gerritbot added a comment.Jul 24 2020, 3:18 PM

Change 616031 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Revert "Selenium: Update to WebdriverIO v6"

https://gerrit.wikimedia.org/r/616031

gerritbot added a comment.Jul 24 2020, 3:42 PM

Change 616112 abandoned by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] Run jobs inside browser.call

Reason:
original patch was reverted

https://gerrit.wikimedia.org/r/616112

Ladsgroup lowered the priority of this task from Unbreak Now! to High.Jul 24 2020, 3:50 PM

Thanks.

Jdlrobson closed this task as Resolved.Jul 24 2020, 4:46 PM
Jdlrobson mentioned this in T256977: Upgrade WebdriverIO in the MobileFrontend repository.

Addressed now. Assuming T256977 covers the rest. Thanks for the quick response!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL