Page MenuHomePhabricator
Create Task
Maniphest T258751

Watchlist Expiry: add cursor pointer to pop-up [SMALL]
Closed, ResolvedPublic
Actions

Description

Acceptance Criteria:

  • Add cursor pointer to pop-up after you first watch the page

Details

SubjectRepoBranchLines +/-
Ensure cursor is pointer for watch-star notificationmediawiki/coreREL1_35+6 -0
Ensure cursor is pointer for watch-star notificationmediawiki/coremaster+6 -0
Customize query in gerrit

Event Timeline

ifried created this task.Jul 23 2020, 8:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2020, 8:44 PM
ifried renamed this task from Watchlist Expiry: make pop-up dismissable to Watchlist Expiry: make pop-up manually dismissable.Jul 23 2020, 8:46 PM
ifried renamed this task from Watchlist Expiry: make pop-up manually dismissable to Watchlist Expiry: add cursor pointer to pop-up.Jul 23 2020, 8:58 PM
ifried updated the task description. (Show Details)
ARamirez_WMF renamed this task from Watchlist Expiry: add cursor pointer to pop-up to Watchlist Expiry: add cursor pointer to pop-up [SMALL].Jul 23 2020, 9:01 PM
ARamirez_WMF moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.
ifried moved this task from Up Next (June 3-21) to Kanban-2020-21-Q1 on the Community-Tech board.Jul 23 2020, 9:20 PM
ifried edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban-2020-21-Q1). · View Herald TranscriptJul 23 2020, 9:20 PM
ifried moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jul 27 2020, 7:53 PM
ARamirez_WMF moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.Jul 28 2020, 7:17 PM
ifried moved this task from Up Next (June 3-21) to Kanban-2020-21-Q1 on the Community-Tech board.Jul 29 2020, 3:50 PM
ifried edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.
Samwilson claimed this task.Jul 30 2020, 1:34 AM
Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q1) board.
gerritbot added a comment.Jul 30 2020, 1:39 AM

Change 617298 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Ensure cursor is pointer for watch-star notification

https://gerrit.wikimedia.org/r/617298

gerritbot added a project: Patch-For-Review.Jul 30 2020, 1:39 AM
gerritbot added a comment.Jul 30 2020, 5:10 AM

Change 617298 merged by jenkins-bot:
[mediawiki/core@master] Ensure cursor is pointer for watch-star notification

https://gerrit.wikimedia.org/r/617298

gerritbot added a comment.Jul 30 2020, 5:15 AM

Change 617314 had a related patch set uploaded (by MusikAnimal; owner: Samwilson):
[mediawiki/core@REL1_35] Ensure cursor is pointer for watch-star notification

https://gerrit.wikimedia.org/r/617314

Samwilson moved this task from In Development 💻 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 30 2020, 5:34 AM

Merged and backported to 1.35. Ready for QA.

gerritbot added a comment.Jul 30 2020, 5:40 AM

Change 617314 merged by jenkins-bot:
[mediawiki/core@REL1_35] Ensure cursor is pointer for watch-star notification

https://gerrit.wikimedia.org/r/617314

ReleaseTaggerBot added projects: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), MW-1.35-notes.Jul 30 2020, 6:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jul 30 2020, 6:10 AM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 31 2020, 3:56 PM
dom_walden subscribed.

When you hover over the watch pop-up (or dropdown) the cursor turns to a pointer.

ifried closed this task as Resolved.Jul 31 2020, 6:06 PM
ifried moved this task from Product sign-off 🤘🏻 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q1) board.

I have tested this, and the cursor pointer now properly displays when the user hovers over clickable content (such as page links or the temporary watch dropdown). For this reason, I'm marking it as Done.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits