| ifried | |
| Jul 23 2020, 9:29 PM |
| F31955343: 255_popup.png | |
| Jul 31 2020, 9:07 AM |
As a watchlist expiry user, I want the pop-up behavior to be updated, so that it properly displays all options for long article titles.
Background: This is a follow-up to issues uncovered in T249262, which we would like to address separately.
Acceptance Criteria:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix pop-up height for watchlist expiry | mediawiki/core | REL1_35 | +4 -7 | |
| Fix pop-up height for watchlist expiry | mediawiki/core | master | +4 -7 |
Change 616642 had a related patch set uploaded (by HMonroy; owner: HMonroy):
[mediawiki/core@master] Fix pop-up height for watchlist expiry
Remember to backport to REL1_35 as well since the commit that caused the regression was also backported (T249262).
Change 616642 merged by jenkins-bot:
[mediawiki/core@master] Fix pop-up height for watchlist expiry
Change 616944 had a related patch set uploaded (by MusikAnimal; owner: HMonroy):
[mediawiki/core@REL1_35] Fix pop-up height for watchlist expiry
Change 616944 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix pop-up height for watchlist expiry
The dropdown now appears fine for a title 255 characters long (the limit).
I don't know where else the notification widget is used, so I did not test if the CSS change will impact other UI components.
Test environment: https://en.wikipedia.beta.wmflabs.org MediaWiki 1.36.0-alpha (72ac5e1) 06:44, 31 July 2020
This looks good, based on the screenshot example provided above. I'm marking this as Done.