Page MenuHomePhabricator
Create Task
Maniphest T258756

Translate extension fails to create translations of module documentation pages
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

Mark the documentation of a module for translation (this happened on MediaWiki.org with Module:Transcluder/doc).

Try to translate the page into another language.

Actual Results:

When the page is marked for translation the "translation" into the source language (Module:Transcluder/doc/en) was not created.

When the page is translated into a new language, the translation page (Module:Transcluder/doc/<language code>) was not created

Expected Results:

Translations of module documentation pages are automatically created in the same manner as translations of all other pages.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Translatemaster+23 -13Fix translation of pages with custom content models
mediawiki/extensions/Translatemaster+2 -1Force translation pages to have same content model as source page
Customize query in gerrit

Related Objects

Event Timeline

Pppery created this task.Jul 23 2020, 10:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 23 2020, 10:13 PM
Shirayuki added a subscriber: Shirayuki.Jul 23 2020, 10:15 PM
Sophivorus added a subscriber: Sophivorus.Jul 23 2020, 11:16 PM
Sophivorus added a comment.EditedJul 23 2020, 11:31 PM

I suspect the issue may be due to the fact that when creating subpages of a module or the /doc subpage, the Translate extension (or MediaWiki core) defaults to the content model of the module.

Tacsipacsi added a project: MediaWiki-extensions-Scribunto.Jul 24 2020, 10:12 AM
Tacsipacsi added a subscriber: Tacsipacsi.

It’s set by Scribunto at rELUA includes/common/Hooks.php:256-273 (at 3b2d40f28de5), not by core or Translate. This code already exempts TemplateStyles (T200914), so probably documentation translations can be exempted, too.

Pppery claimed this task.Jul 25 2020, 5:50 PM
gerritbot added a comment.Jul 25 2020, 5:54 PM

Change 616281 had a related patch set uploaded (by Pppery; owner: Pppery):
[mediawiki/extensions/Translate@master] Force translation pages to have same content model as source page

https://gerrit.wikimedia.org/r/616281

gerritbot added a project: Patch-For-Review.Jul 25 2020, 5:54 PM
Legoktm added a subscriber: Legoktm.Aug 9 2020, 12:21 AM

The patch seems fine to me. One other idea I had was if we made Scribunto::isDocPage true for /doc and any of its subpages, which would include translation pages. Is there any use case for having Lua pages under Module:Foo/doc/... ? Or any reason we shouldn't do that and only do it for i18n pages?

Pppery added a comment.Aug 9 2020, 12:30 AM

My patch to the translate extension would be a good idea regardless, as it fixes the case where a non-doc page is manually given the wikitext content model (through an explicit content model change or a move), and then marked for translation.

gerritbot added a comment.Aug 10 2020, 8:09 AM

Change 616281 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Force translation pages to have same content model as source page

https://gerrit.wikimedia.org/r/616281

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 8:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).Aug 10 2020, 9:00 AM
Pppery closed this task as Resolved.EditedAug 11 2020, 4:26 PM

Confirmed fixed (the linked edit was caused by a null edit to a Translations namespace page)

Pppery reopened this task as Open.May 24 2021, 7:36 PM

This seems to have regressed at some point, as FuzzyBot failed to create https://www.mediawiki.org/wiki/Module:Template_translation/doc/en when https://www.mediawiki.org/wiki/Module:Template_translation/doc was marked for translation.

Pppery removed Pppery as the assignee of this task.May 24 2021, 7:58 PM
Pppery claimed this task.May 25 2021, 12:05 AM
gerritbot added a comment.May 25 2021, 12:09 AM

Change 693984 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/Translate@master] Fix translation of pages with custom content models

https://gerrit.wikimedia.org/r/693984

gerritbot added a project: Patch-For-Review.May 25 2021, 12:09 AM
Sophivorus removed a subscriber: Sophivorus.May 25 2021, 12:37 AM
ExE-Boss added a subscriber: ExE-Boss.Jun 11 2021, 3:31 AM
Nikerabbit added a project: Language-Team (Language-2021-July-September).Jul 19 2021, 11:09 AM
Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-July-September) board.
Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.
gerritbot added a comment.Aug 9 2021, 10:06 AM

Change 693984 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Fix translation of pages with custom content models

https://gerrit.wikimedia.org/r/693984

Maintenance_bot removed a project: Patch-For-Review.Aug 9 2021, 10:10 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 9 2021, 11:00 AM
Tacsipacsi mentioned this in T288683: FuzzyBot overwriting fully translated pages with original text.Aug 11 2021, 11:14 PM
Nikerabbit closed this task as Resolved.Aug 25 2021, 10:18 AM
Nikerabbit moved this task from In Review to Done on the Language-Team (Language-2021-July-September) board.
Tacsipacsi mentioned this in T289230: Translate extension finds translation markup on JsonConfig pages.Sep 1 2021, 7:44 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL