Page MenuHomePhabricator

WikEdDiff and DiscussionTool's Reply feature don't always work together
Closed, ResolvedPublic

Description

Per @Tacsipacsi at https://hu.wikipedia.org/w/index.php?title=Wikipédia-vita:Válaszeszköz&oldid=22880382#Usefulness

Sometimes, if you're looking at a page in WikEdDiff, then clicking the [Reply] button produces this error: "Could not find the comment you're replying to on the page. It might have been deleted or moved to another page. Please reload the page and try again."

Reloading the page often solves the problem (so, maybe a race condition?).

Event Timeline

One of wikEdDiff’s distinctive features is that it turns the [[]] and {{}} codes in the normal MediaWiki diff into links, which makes signatures in the diff pretty much the same as signatures in the rendered text (both have timestamps, both have links to user/user talk pages, and both are at the end of a line). Although I’m not 100% sure, this bug seems to appear only when [reply] links are added within the diff (=when wikEdDiff was faster and this transformation was already done when DT checked the page for signatures), and only when using the [reply] links in the actual page text (i.e. not in the diff). If that’s right, this bug can be fixed by searching for signatures only in #mw-content-text > .mw-parser-output, which excludes the diff. (By the way, MediaWiki-extensions-WikEdDiff is a PHP extension, not the JavaScript gadget I use. They are connected, but not the same, so this tag might not be appropriate here.)

@Tacsipacsi are you able to share how you calculated use of the MediaWiki-extensions-WikEdDiff extension at hu.wiki [i]?

Context: in thinking about how we prioritize this issue, I am curious to learn who is using WikEdDiff and with what frequency they are using it.


i. https://hu.wikipedia.org/w/index.php?title=Wikip%C3%A9dia-vita%3AV%C3%A1laszeszk%C3%B6z&type=revision&diff=22880230&oldid=22877704

Gadget usage data is available at Special:GadgetUsage, which contains anonymized figures about how many users turned gadgets on in their preferences (the answer to who is not publicly available, but of course can be queried from the database if you have sufficient permissions). Please note that this is an underestimation, as it doesn’t contain users who installed these gadgets using their common.js, vector.js, global.js etc. subpages, or other methods like using Greasemonkey. Also, please consider T252555#6339223 when prioritizing this.

Gadget usage data is available at Special:GadgetUsage, which contains anonymized figures about how many users turned gadgets on in their preferences

Neat – this is the first time I'm seeing this page...thank you for sharing it.

Also, please consider T252555#6339223 when prioritizing this.

Definitely. Per what you shared in the above [i] and considering we are currently implementing T258815, I'm moving this ticket to the backlog.


i.

In T252555#6339223, @Tacsipacsi wrote:

If no reply links are generated at the client side, T252555 will no longer be a bug (yay!).

The patch for T252555 is deployed now, and this should be fixed as well. @Tacsipacsi Can you confirm that the issue no longer occurs?

@matmarex The bug hasn’t occurred always even before, “only” nine times out of ten, so I can’t say for absolutely sure, but I haven’t experienced it since the deployment at all (although I haven’t used talk pages a lot on huwiki since then).

@matmarex The bug hasn’t occurred always even before, “only” nine times out of ten, so I can’t say for absolutely sure, but I haven’t experienced it since the deployment at all (although I haven’t used talk pages a lot on huwiki since then).

@matmarex, thank you for asking and @Tacsipacsi, thank you for checking.

I'm going to close this ticket for now. If/when you encounter this issue again, please re-open this task (if you remember!).

ppelberg claimed this task.