Page MenuHomePhabricator
Create Task
Maniphest T258846

Editor should not use OverlayManager.replaceCurrent
Open, Needs TriagePublic
Actions

Description

The replaceCurrent method has been an anti-pattern for some time. It replaces the existing overlay and updates OverlayManager internals. It can be avoided by using a wrapping component e.g. associate a single Overlay with a single element and use the promisedView to alter views within the overlay itself.

The only overlays using replaceCurrent are the category overlay (taken care of in the refactor T212465) and the editor overlays.

A proof of concept demonstrates what's possible without the replaceCurrent method in the codebase:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/616175

I (@Jdlrobson) can provide code if others who know the editor better can provide review.

Note: The category code using replaceCurrent is to be removed as part of T246049.

Details

SubjectRepoBranchLines +/-
WIP: Simplify editor switching to not use overlay manager replaceCurrentmediawiki/extensions/MobileFrontendmaster+267 -140
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 24 2020, 10:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2020, 10:59 PM
Jdlrobson added a project: Technical-Debt.Jul 24 2020, 10:59 PM
JTannerWMF moved this task from To Triage to Triaged on the VisualEditor board.Jul 28 2020, 3:39 PM
JTannerWMF added projects: Editing-Team-Request, Editing-team (Tracking).
JTannerWMF subscribed.

Hey @Jdlrobson , feel free to write the code and the Editing team will perform review when ready

JTannerWMF moved this task from Backlog to Dependent on others on the Editing-team (Tracking) board.Jul 28 2020, 3:39 PM
gerritbot added a comment.Aug 13 2020, 10:00 PM

Change 620127 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] WIP: Simplify editor switching to not use overlay manager replaceCurrent

https://gerrit.wikimedia.org/r/620127

gerritbot added a project: Patch-For-Review.Aug 13 2020, 10:00 PM
gerritbot added a comment.Jan 22 2021, 1:49 AM

Change 620127 abandoned by Jdlrobson:
[mediawiki/extensions/MobileFrontend@master] WIP: Simplify editor switching to not use overlay manager replaceCurrent

Reason:
Gonna try finding away to avoid having to touch the editor as part of a migration to Vue. Will make life a lot simpler.

https://gerrit.wikimedia.org/r/620127

Jdlrobson renamed this task from Editor and category overlays should not use OverlayManager.replaceCurrent to Editor should not use OverlayManager.replaceCurrent.Apr 27 2021, 9:44 PM
Jdlrobson updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Apr 27 2021, 10:10 PM
Jdlrobson added a parent task: T281930: [EPIC] Migrate MobileFrontend's code to Vue.js and Codex.May 4 2021, 11:17 PM
Jdlrobson edited projects, added MobileFrontend (MobileFrontend (Editor)); removed MobileFrontend (MobileFrontend and MinervaNeue architecture).Nov 30 2021, 5:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits