Page MenuHomePhabricator

UploadWizard generates an HTTP (not HTTPS) link post-upload
Open, LowPublicBUG REPORT

Description

Steps to Reproduce: Upload a file to Commons.

Actual Results: the post-upload screen offers you an HTTP:// link to the file just created. It should be HTTPS.

Expected Results:

Event Timeline

Ijon created this task.Jul 26 2020, 8:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2020, 8:34 AM

Oh crap, the screen capture didn't catch the beginning of the URL. Meh.

MarkTraceur triaged this task as Low priority.Jul 26 2020, 8:50 PM
MarkTraceur added a subscriber: MarkTraceur.

@Aklapper I think the line at issue in that file is https://phabricator.wikimedia.org/diffusion/EUWI/browse/master/resources/ui/steps/uw.ui.Thanks.js$146

...however, I don't see how that could be the problem, as it's passing in verbatim what the action=upload API call returned on successful publish.

The issue is more likely to be in the backend API, as far as I can tell...though a little bit of weekend digging didn't yield me any obvious reasons why wfExpandUrl or FileRepo::getDescriptionUrl would be returning a protocol that Commons doesn't even have configured.

(prioritizing as low, since our traffic is all redirected anyway, but I may circle back during, like, work hours to take another look if I get a chance)

Update: Couldn't reproduce on beta, at least not with an image - chunked uploads may be treated differently somehow, certainly worth investigating still

Ijon added a comment.Sep 6 2020, 7:59 AM

Indeed, I got this uploading large (~300MB) video files. Here's a fresh screencap.