Page MenuHomePhabricator
Create Task
Maniphest T258936

Move Echo/Notifications CSS code out of Minerva
Closed, DuplicatePublic
Actions

Description

Echo/Notifications can just use skinStyles, instead of Minerva having to know about an extension.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove styles moved over to Echomediawiki/skins/MinervaNeuemaster+0 -63
Merge in styles from Minervamediawiki/extensions/Echomaster+47 -1
Customize query in gerrit

Event Timeline

Esanders created this task.Jul 27 2020, 11:55 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 27 2020, 11:55 AM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
gerritbot added a comment.Jul 27 2020, 8:16 PM

Change 616588 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Merge in styles from Minerva

https://gerrit.wikimedia.org/r/616588

gerritbot added a project: Patch-For-Review.Jul 27 2020, 8:16 PM

Change 616590 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Remove styles moved over to Echo

https://gerrit.wikimedia.org/r/616590

gerritbot added a comment.Jul 28 2020, 10:53 AM

Change 616588 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Merge in styles from Minerva

https://gerrit.wikimedia.org/r/616588

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 28 2020, 11:00 AM
gerritbot added a comment.Jul 28 2020, 1:10 PM

Change 616590 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove styles moved over to Echo

https://gerrit.wikimedia.org/r/616590

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2020, 2:10 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
Jdlrobson moved this task from Backlog to Tech debt on the MinervaNeue board.Jul 21 2021, 7:24 PM
Jdlrobson moved this task from Tech debt to Code organisation on the MinervaNeue board.Jul 21 2021, 8:27 PM
Izno subscribed.Apr 11 2023, 5:29 AM

Is this task done?

Jdlrobson closed this task as a duplicate of T257143: Clean up the technical debt and inconsistencies of notification icon (Echo badge) positioning in different skins.Apr 11 2023, 3:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits