Page MenuHomePhabricator

Special:Notifications filter overlay never closes in Minerva
Closed, ResolvedPublic

Description

On Special:Notifications in Minerva

  1. Click "Filter notifications"
  2. Make a selection
  3. Observe the page still has a grey overlay and you can't interact with the page.

Merged task (T259091) details:

The issue was found in wmf.1, wmf.2 and betalabs. It's reproducible on real devices (I checked iOS and Android) and in browsers' emulators

  1. On mobile go to Special:Notifications page
  2. Click "Filter notifications"
  3. Select one of the options - "All", "Read", "Unread" or select another wiki with notifications

The dark overlay will be displayed making the page non-responsive to all interactions

Screen Shot 2020-07-28 at 6.42.31 PM.png (572×319 px, 42 KB)

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript

Change 617548 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@master] Mobile Special:Notifications: Properly close overlay on selection

https://gerrit.wikimedia.org/r/617548

Change 617548 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Mobile Special:Notifications: Properly close overlay on selection

https://gerrit.wikimedia.org/r/617548

Change 617443 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@wmf/1.36.0-wmf.2] Mobile Special:Notifications: Properly close overlay on selection

https://gerrit.wikimedia.org/r/617443

Change 617444 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Echo@wmf/1.36.0-wmf.1] Mobile Special:Notifications: Properly close overlay on selection

https://gerrit.wikimedia.org/r/617444

Change 617443 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.36.0-wmf.2] Mobile Special:Notifications: Properly close overlay on selection

https://gerrit.wikimedia.org/r/617443

Change 617444 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.36.0-wmf.1] Mobile Special:Notifications: Properly close overlay on selection

https://gerrit.wikimedia.org/r/617444

Mentioned in SAL (#wikimedia-operations) [2020-07-31T00:06:17Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.1/extensions/Echo/modules/mobile/notificationsFilterOverlay.js: T258954 (duration: 01m 10s)

Mentioned in SAL (#wikimedia-operations) [2020-07-31T00:07:24Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.2/extensions/Echo/modules/mobile/notificationsFilterOverlay.js: T258954 (duration: 01m 06s)