Page MenuHomePhabricator
Create Task
Maniphest T259013

puppet: drop legacy validate_ functions
Closed, ResolvedPublic
Actions

Description

update the puppet manifests to drop the validate_ functions and replace them with parameter type enforcement

Details

SubjectRepoBranchLines +/-
cumin: fix aliasesoperations/puppetproduction+1 -2
role::logstash::collector: remove unused roleoperations/puppetproduction+1 -26
validate_$type: add checks to prevent legacy stdlib functionsoperations/puppet-lint/wmf_styleguide-checkmaster+35 -0
service: drop legacy validate functionsoperations/puppetproduction+54 -57
wmflib: drop validate functionsoperations/puppetproduction+2 -70
logstash::input::tcp: drop validate functionsoperations/puppetproduction+9 -15
kartotherian: drop validate_array functionoperations/puppetproduction+0 -2
role::logstash::puppetboard: refactor roleoperations/puppetproduction+36 -23
role::logstash7: refactor role to conform to coding guideoperations/puppetproduction+10 -31
casandra: drop legacy _validate_ functionsoperations/puppetproduction+104 -179
profile::openstack: drop legacy validate_ functionsoperations/puppetproduction+18 -22
prometheus: drop legacy validate_functionsoperations/puppetproduction+52 -58
graphite::web: drop validate_functions and add type validationoperations/puppetproduction+14 -16
cassandra::metrics: drop legacy functionsoperations/puppetproduction+6 -15
sslcert: drop validate_ functionsoperations/puppetproduction+8 -13
keyholder: drop legacy validate functionsoperations/puppetproduction+9 -9
profile::mariadb::eventloggin: drop legacy validate_ functionoperations/puppetproduction+2 -5
profile::redis::master: drop legacy validate_ functionsoperations/puppetproduction+17 -17
sysfs::confile: drop legacy functions and add type validationoperations/puppetproduction+5 -8
tmpreaper: drop legacy validate_ functionsoperations/puppetproduction+9 -14
statsd_proxy: drop validate functionsoperations/puppetproduction+5 -9
sudo: drop validate functionsoperations/puppetproduction+5 -8
udev::rule: drop legacy validate functionsoperations/puppetproduction+4 -6
mtail: drop legacy validate functions and add type validationoperations/puppetproduction+5 -8
postgresql: drop validate_functions and add type enforcmentoperations/puppetproduction+3 -4
security::pam: drop validate_functions and add type enforcmentoperations/puppetproduction+3 -5
kmod: drop legacy validate_ functionsoperations/puppetproduction+6 -7
redis: fix legacy validate functionsoperations/puppetproduction+5 -8
tillerator: drop legacu validate_ functionsoperations/puppetproduction+0 -2
zuul: drop validate functionsoperations/puppetproduction+1 -2
Show related patches Customize query in gerrit

Event Timeline

jbond created this task.Jul 28 2020, 10:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2020, 10:27 AM
jbond renamed this task from puppet: drop legacy validat_ functions to puppet: drop legacy validate_ functions.Jul 28 2020, 10:27 AM
jbond triaged this task as Low priority.
gerritbot added a comment.Jul 28 2020, 11:10 AM

Change 616732 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] cassandra::metrics: drop legacy functions

https://gerrit.wikimedia.org/r/616732

gerritbot added a project: Patch-For-Review.Jul 28 2020, 11:10 AM

Change 616733 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] casandra::instance: drop lgacey _validate_ functions

https://gerrit.wikimedia.org/r/616733

gerritbot added a comment.Jul 28 2020, 11:31 AM

Change 616735 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] mtail: drop legacy validate functions and add type validation

https://gerrit.wikimedia.org/r/616735

gerritbot added a comment.Jul 28 2020, 11:31 AM

Change 616736 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] sysfs::confile: drop legacy functions and add type validation

https://gerrit.wikimedia.org/r/616736

gerritbot added a comment.Jul 28 2020, 11:31 AM

Change 616737 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] udev::rule: drop legacy validate functions

https://gerrit.wikimedia.org/r/616737

gerritbot added a comment.Jul 28 2020, 11:31 AM

Change 616738 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] graphite::web: drop validate_functions and add type validation

https://gerrit.wikimedia.org/r/616738

gerritbot added a comment.Jul 28 2020, 11:31 AM

Change 616739 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] profile::redis::master: drop legacy validate_ functions

https://gerrit.wikimedia.org/r/616739

gerritbot added a comment.Jul 28 2020, 11:31 AM

Change 616740 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] profile::mariadb::eventloggin: drop legacy validate_ function

https://gerrit.wikimedia.org/r/616740

gerritbot added a comment.Jul 28 2020, 11:41 AM

Change 616742 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] profile::openstack: drop legacy validate_ functions

https://gerrit.wikimedia.org/r/616742

gerritbot added a comment.Jul 28 2020, 11:41 AM

Change 616743 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] tmpreaper: drop legacy validate_ functions

https://gerrit.wikimedia.org/r/616743

gerritbot added a comment.Jul 28 2020, 11:41 AM

Change 616744 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] postgresql: drop validate_functions and add type enforcment

https://gerrit.wikimedia.org/r/616744

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616747 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] security::pam: drop validate_functions and add type enforcment

https://gerrit.wikimedia.org/r/616747

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616748 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] kmod: drop legacy validate_ functions

https://gerrit.wikimedia.org/r/616748

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616749 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] keyholder: drop legacy validate functions

https://gerrit.wikimedia.org/r/616749

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616750 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] sslcert: drop validate_ functions

https://gerrit.wikimedia.org/r/616750

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616751 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] redis: fix legacy validate functions

https://gerrit.wikimedia.org/r/616751

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616752 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] tillerator: drop legacu validate_ functions

https://gerrit.wikimedia.org/r/616752

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616753 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] prometheus: drop legacy validate_functions

https://gerrit.wikimedia.org/r/616753

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616754 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] zuul: drop validate functions

https://gerrit.wikimedia.org/r/616754

gerritbot added a comment.Jul 28 2020, 12:24 PM

Change 616755 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] statsd_proxy: drop validate functions

https://gerrit.wikimedia.org/r/616755

gerritbot added a comment.Jul 28 2020, 12:43 PM

Change 616757 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] sudo: drop validate functions

https://gerrit.wikimedia.org/r/616757

gerritbot added a comment.Jul 28 2020, 12:43 PM

Change 616758 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] service: drop legacy validate functions

https://gerrit.wikimedia.org/r/616758

gerritbot added a comment.Jul 28 2020, 1:50 PM

Change 616754 merged by Jbond:
[operations/puppet@production] zuul: drop validate functions

https://gerrit.wikimedia.org/r/616754

gerritbot added a comment.Jul 28 2020, 1:50 PM

Change 616752 merged by Jbond:
[operations/puppet@production] tillerator: drop legacu validate_ functions

https://gerrit.wikimedia.org/r/616752

gerritbot added a comment.Jul 28 2020, 1:50 PM

Change 616751 merged by Jbond:
[operations/puppet@production] redis: fix legacy validate functions

https://gerrit.wikimedia.org/r/616751

gerritbot added a comment.Jul 28 2020, 1:51 PM

Change 616748 merged by Jbond:
[operations/puppet@production] kmod: drop legacy validate_ functions

https://gerrit.wikimedia.org/r/616748

gerritbot added a comment.Jul 28 2020, 1:51 PM

Change 616747 merged by Jbond:
[operations/puppet@production] security::pam: drop validate_functions and add type enforcment

https://gerrit.wikimedia.org/r/616747

gerritbot added a comment.Jul 28 2020, 1:51 PM

Change 616744 merged by Jbond:
[operations/puppet@production] postgresql: drop validate_functions and add type enforcment

https://gerrit.wikimedia.org/r/616744

gerritbot added a comment.Jul 28 2020, 1:52 PM

Change 616735 merged by Jbond:
[operations/puppet@production] mtail: drop legacy validate functions and add type validation

https://gerrit.wikimedia.org/r/616735

gerritbot added a comment.Jul 28 2020, 1:53 PM

Change 616737 merged by Jbond:
[operations/puppet@production] udev::rule: drop legacy validate functions

https://gerrit.wikimedia.org/r/616737

gerritbot added a comment.Jul 28 2020, 2:07 PM

Change 616757 merged by Jbond:
[operations/puppet@production] sudo: drop validate functions

https://gerrit.wikimedia.org/r/616757

gerritbot added a comment.Jul 28 2020, 2:12 PM

Change 616755 merged by Jbond:
[operations/puppet@production] statsd_proxy: drop validate functions

https://gerrit.wikimedia.org/r/616755

gerritbot added a comment.Jul 28 2020, 2:17 PM

Change 616743 merged by Jbond:
[operations/puppet@production] tmpreaper: drop legacy validate_ functions

https://gerrit.wikimedia.org/r/616743

gerritbot added a comment.Jul 28 2020, 2:18 PM

Change 616736 merged by Jbond:
[operations/puppet@production] sysfs::confile: drop legacy functions and add type validation

https://gerrit.wikimedia.org/r/616736

gerritbot added a comment.Jul 28 2020, 3:07 PM

Change 616739 merged by Jbond:
[operations/puppet@production] profile::redis::master: drop legacy validate_ functions

https://gerrit.wikimedia.org/r/616739

gerritbot added a comment.Jul 28 2020, 3:11 PM

Change 616740 merged by Jbond:
[operations/puppet@production] profile::mariadb::eventloggin: drop legacy validate_ function

https://gerrit.wikimedia.org/r/616740

gerritbot added a comment.Jul 28 2020, 3:18 PM

Change 616749 merged by Jbond:
[operations/puppet@production] keyholder: drop legacy validate functions

https://gerrit.wikimedia.org/r/616749

gerritbot added a comment.Jul 28 2020, 3:49 PM

Change 616750 merged by Jbond:
[operations/puppet@production] sslcert: drop validate_ functions

https://gerrit.wikimedia.org/r/616750

gerritbot added a comment.Jul 28 2020, 4:00 PM

Change 616732 abandoned by Jbond:
[operations/puppet@production] cassandra::metrics: drop legacy functions

Reason:
squashed with https://gerrit.wikimedia.org/r/c/operations/puppet/ /616733/2

https://gerrit.wikimedia.org/r/616732

gerritbot added a comment.Jul 28 2020, 7:28 PM

Change 616895 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet-lint/wmf_styleguide-check@master] validate_$type: add checks to prevent legacy stdlib functions

https://gerrit.wikimedia.org/r/616895

gerritbot added a comment.Jul 29 2020, 9:48 AM

Change 616738 merged by Jbond:
[operations/puppet@production] graphite::web: drop validate_functions and add type validation

https://gerrit.wikimedia.org/r/616738

gerritbot added a comment.Jul 29 2020, 9:50 AM

Change 616753 merged by Jbond:
[operations/puppet@production] prometheus: drop legacy validate_functions

https://gerrit.wikimedia.org/r/616753

gerritbot added a comment.Jul 29 2020, 10:41 AM

Change 617085 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] role::logstash::apifeature: refactor role to profile

https://gerrit.wikimedia.org/r/617085

gerritbot added a comment.Jul 29 2020, 11:15 AM

Change 617087 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] role::logstash::puppetboard: refactor role

https://gerrit.wikimedia.org/r/617087

gerritbot added a comment.Jul 29 2020, 11:27 AM

Change 617090 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] role::logstash::collector: remove unused role

https://gerrit.wikimedia.org/r/617090

gerritbot added a comment.Jul 29 2020, 11:41 AM

Change 617095 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] role::logstash7: refactor role to conform to coding guide

https://gerrit.wikimedia.org/r/617095

gerritbot added a comment.Aug 31 2020, 3:01 PM

Change 616742 merged by Jbond:
[operations/puppet@production] profile::openstack: drop legacy validate_ functions

https://gerrit.wikimedia.org/r/616742

gerritbot added a comment.Oct 6 2020, 10:54 AM

Change 616733 merged by Jbond:
[operations/puppet@production] casandra: drop legacy _validate_ functions

https://gerrit.wikimedia.org/r/616733

gerritbot added a comment.Oct 6 2020, 3:40 PM

Change 617095 merged by Jbond:
[operations/puppet@production] role::logstash7: refactor role to conform to coding guide

https://gerrit.wikimedia.org/r/617095

gerritbot added a comment.Oct 6 2020, 3:43 PM

Change 617087 merged by Jbond:
[operations/puppet@production] role::logstash::puppetboard: refactor role

https://gerrit.wikimedia.org/r/617087

gerritbot added a comment.Oct 6 2020, 4:02 PM

Change 617090 merged by Jbond:
[operations/puppet@production] role::logstash::collector: remove unused role

https://gerrit.wikimedia.org/r/617090

gerritbot added a comment.Oct 6 2020, 5:18 PM

Change 632526 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] kartotherian: drop validate_array function

https://gerrit.wikimedia.org/r/632526

gerritbot added a comment.Oct 6 2020, 5:19 PM

Change 632526 merged by Jbond:
[operations/puppet@production] kartotherian: drop validate_array function

https://gerrit.wikimedia.org/r/632526

gerritbot added a comment.Oct 6 2020, 5:22 PM

Change 632527 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] logstash::input::tcp: drop validate functions

https://gerrit.wikimedia.org/r/632527

gerritbot added a comment.Oct 6 2020, 5:23 PM

Change 632527 merged by Jbond:
[operations/puppet@production] logstash::input::tcp: drop validate functions

https://gerrit.wikimedia.org/r/632527

gerritbot added a comment.Oct 6 2020, 5:30 PM

Change 632529 had a related patch set uploaded (by Jbond; owner: John Bond):
[operations/puppet@production] wmflib: drop validate functions

https://gerrit.wikimedia.org/r/632529

gerritbot added a comment.Oct 6 2020, 5:32 PM

Change 632529 merged by Jbond:
[operations/puppet@production] wmflib: drop validate functions

https://gerrit.wikimedia.org/r/632529

gerritbot added a comment.Oct 7 2020, 9:56 AM

Change 616758 merged by Jbond:
[operations/puppet@production] service: drop legacy validate functions

https://gerrit.wikimedia.org/r/616758

gerritbot added a comment.Oct 7 2020, 10:12 AM

Change 616895 merged by Jbond:
[operations/puppet-lint/wmf_styleguide-check@master] validate_$type: add checks to prevent legacy stdlib functions

https://gerrit.wikimedia.org/r/616895

gerritbot added a comment.Oct 19 2020, 7:25 AM

Change 634908 had a related patch set uploaded (by Volans; owner: Volans):
[operations/puppet@production] cumin: fix aliases

https://gerrit.wikimedia.org/r/634908

gerritbot added a comment.Oct 19 2020, 7:28 AM

Change 634908 merged by Volans:
[operations/puppet@production] cumin: fix aliases

https://gerrit.wikimedia.org/r/634908

jbond closed this task as Resolved.Nov 20 2020, 11:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL