Description

Trying this translation on the Section Translation test server, I found some text instances in the confirmation step and the list of sections where text is cropped. In the first case very heavily. In the second one, only for text descenders (e.g., low part of "g").

The screenshots below illustrate the issue:

photo_2020-07-28 12.49.16.jpeg (1×591 px, 90 KB)

photo_2020-07-28 12.49.13.jpeg (1×591 px, 78 KB)

I found the issue on Chrome both on mobile (Android) and desktop (Mac)

Details

Subject	Repo	Branch	Lines +/-
SXSectionSelector: Fix UI glitch for section item buttons	mediawiki/extensions/ContentTranslation	master	+13 -19
SXSectionSelector: Fix line height issues inside buttons	mediawiki/extensions/ContentTranslation	master	+13 -9
SX ArticleSelector: Fix the partially visible article title	mediawiki/extensions/ContentTranslation	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T243495 [Epic] Support for Section Translation
		Resolved	BUG REPORT	ngkountas	T259016 Line height issues partially crop text in Section Translation workflow

Event Timeline

Pginer-WMF created this task.Jul 28 2020, 10:51 AM

Pginer-WMF added a project: SectionTranslation.Jul 28 2020, 1:15 PM

Pginer-WMF removed a project: CX-boost.

Pginer-WMF moved this task from Backlog to General infrastructure on the SectionTranslation board.Jul 28 2020, 1:24 PM

Pginer-WMF triaged this task as Medium priority.Jul 30 2020, 8:09 AM

Pginer-WMF edited projects, added Language-Team (Language-2020-July-September); removed Language-Team (Language-2020-Focus-Sprint).Aug 3 2020, 7:45 AM

Change 619447 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] SX ArticleSelector: Fix the partially visiable article title

https://gerrit.wikimedia.org/r/619447

gerritbot added a project: Patch-For-Review.Aug 11 2020, 9:46 AM

Change 619447 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX ArticleSelector: Fix the partially visible article title

https://gerrit.wikimedia.org/r/619447

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Aug 11 2020, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 11 2020, 1:10 PM

The issue about section title heights(shown in second screenshot) is not fixed yet

Change 619718 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXSectionSelector: Fix line height issues inside buttons

https://gerrit.wikimedia.org/r/619718

gerritbot added a project: Patch-For-Review.Aug 12 2020, 10:18 AM

ngkountas moved this task from Quarter Backlog to In Review on the Language-Team (Language-2020-July-September) board.Aug 12 2020, 11:04 AM

• Rileych assigned this task to ngkountas.Aug 13 2020, 12:42 PM

Change 619718 abandoned by Nik Gkountas:
[mediawiki/extensions/ContentTranslation@master] SXSectionSelector: Fix line height issues inside buttons

Reason:
Line height fixed by changes for mw-button in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/ /619742

https://gerrit.wikimedia.org/r/619718

• Rileych moved this task from In Review to Needs QA on the Language-Team (Language-2020-July-September) board.Aug 20 2020, 12:39 PM

In T259016#6378858, @santhosh wrote:

The issue about section title heights(shown in second screenshot) is not fixed yet

why is this in QA then?

• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2020-July-September) board.Aug 21 2020, 10:25 AM

this needs fixing, moving it to in progress

Arjunaraoc subscribed.Sep 4 2020, 10:29 PM

Change 626646 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXSectionSelector: Fix UI glitch for section item buttons

https://gerrit.wikimedia.org/r/626646

ngkountas moved this task from In Progress to In Review on the Language-Team (Language-2020-July-September) board.Sep 11 2020, 12:58 PM

Change 626646 merged by Santhosh:
[mediawiki/extensions/ContentTranslation@master] SXSectionSelector: Fix UI glitch for section item buttons

https://gerrit.wikimedia.org/r/626646

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.9; 2020-09-15); removed MW-1.36-notes (1.36.0-wmf.5; 2020-08-18).Sep 14 2020, 12:00 PM

ngkountas moved this task from In Review to Needs QA on the Language-Team (Language-2020-July-September) board.Sep 17 2020, 8:14 AM

• Jpita moved this task from Needs QA to Pending input for QA on the Language-Team (Language-2020-July-September) board.Sep 19 2020, 8:13 PM

This comment was removed by • Jpita.

• Jpita moved this task from Pending input for QA to Done on the Language-Team (Language-2020-July-September) board.Sep 19 2020, 9:00 PM

Pginer-WMF closed this task as Resolved.Sep 24 2020, 8:20 AM

	F31951327: photo_2020-07-28 12.49.16.jpeg
	Jul 28 2020, 10:51 AM

	F31951329: photo_2020-07-28 12.49.13.jpeg
	Jul 28 2020, 10:51 AM

	F32356008: image.png
	Sep 19 2020, 8:13 PM

	F32356011: image.png
	Sep 19 2020, 8:13 PM

Line height issues partially crop text in Section Translation workflowClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related ObjectsSearch...

Event Timeline

Line height issues partially crop text in Section Translation workflow
Closed, ResolvedPublicBUG REPORT
Actions

Related Objects
Search...