Page MenuHomePhabricator
Create Task
Maniphest T259023

PHP Notice: Undefined index: content-disposition
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.2

message
PHP Notice: Undefined index: content-disposition

Impact

A dozen of these occurred after promoting to group0. Might be a fluke, but just in case it's something bad that needs fixing, flagging as UBN so someone who understands the code takes a look.

Notes

Details

Request ID
0beba759-a4c0-41e4-bccf-51858d006a7b
Request URL
https://www.mediawiki.org/w/index.php?title=Special:CreateAccount&returnto=Help%3AImages
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.36.0-wmf.2/includes/libs/filebackend/SwiftFileBackend.php(212): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.2/includes/libs/filebackend/SwiftFileBackend.php(1707): SwiftFileBackend->extractMutableContentHeaders(array)
#2 /srv/mediawiki/php-1.36.0-wmf.2/includes/libs/filebackend/SwiftFileBackend.php(1683): SwiftFileBackend->getStatFromHeaders(array)
#3 /srv/mediawiki/php-1.36.0-wmf.2/includes/libs/filebackend/SwiftFileBackend.php(727): SwiftFileBackend->doGetFileStatMulti(array)
#4 /srv/mediawiki/php-1.36.0-wmf.2/includes/libs/filebackend/FileBackendStore.php(728): SwiftFileBackend->doGetFileStat(array)
#5 /srv/mediawiki/php-1.36.0-wmf.2/includes/libs/filebackend/FileBackendStore.php(648): FileBackendStore->getFileStat(array)
#6 /srv/mediawiki/php-1.36.0-wmf.2/includes/libs/filebackend/FileBackendMultiWrite.php(640): FileBackendStore->fileExists(array)
#7 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/FancyCaptcha/includes/FancyCaptcha.php(345): FileBackendMultiWrite->fileExists(array)
#8 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/FancyCaptcha/includes/FancyCaptcha.php(297): FancyCaptcha->pickImageFromList(string, array, integer)
#9 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/FancyCaptcha/includes/FancyCaptcha.php(200): FancyCaptcha->pickImageFromDir(string, integer)
#10 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/FancyCaptcha/includes/FancyCaptcha.php(242): FancyCaptcha->pickImageDir(string, integer, integer)
#11 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/FancyCaptcha/includes/FancyCaptcha.php(242): FancyCaptcha->pickImageDir(string, integer, integer)
#12 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/FancyCaptcha/includes/FancyCaptcha.php(242): FancyCaptcha->pickImageDir(string, integer, integer)
#13 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/FancyCaptcha/includes/FancyCaptcha.php(188): FancyCaptcha->pickImageDir(string, integer, integer)
#14 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/FancyCaptcha/includes/FancyCaptcha.php(451): FancyCaptcha->pickImage()
#15 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/SimpleCaptcha/SimpleCaptcha.php(1154): FancyCaptcha->getCaptcha()
#16 /srv/mediawiki/php-1.36.0-wmf.2/extensions/ConfirmEdit/includes/auth/CaptchaPreAuthenticationProvider.php(70): SimpleCaptcha->createAuthenticationRequest()
#17 /srv/mediawiki/php-1.36.0-wmf.2/includes/auth/AuthManager.php(2127): CaptchaPreAuthenticationProvider->getAuthenticationRequests(string, array)
#18 /srv/mediawiki/php-1.36.0-wmf.2/includes/auth/AuthManager.php(2105): MediaWiki\Auth\AuthManager->getAuthenticationRequestsInternal(string, array, array, User)
#19 /srv/mediawiki/php-1.36.0-wmf.2/includes/specialpage/AuthManagerSpecialPage.php(275): MediaWiki\Auth\AuthManager->getAuthenticationRequests(string, User)
#20 /srv/mediawiki/php-1.36.0-wmf.2/includes/specialpage/LoginSignupSpecialPage.php(143): AuthManagerSpecialPage->loadAuth(NULL)
#21 /srv/mediawiki/php-1.36.0-wmf.2/includes/specialpage/LoginSignupSpecialPage.php(235): LoginSignupSpecialPage->load(NULL)
#22 /srv/mediawiki/php-1.36.0-wmf.2/includes/specialpage/SpecialPage.php(600): LoginSignupSpecialPage->execute(NULL)
#23 /srv/mediawiki/php-1.36.0-wmf.2/includes/specialpage/SpecialPageFactory.php(635): SpecialPage->run(NULL)
#24 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(307): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#25 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(940): MediaWiki->performRequest()
#26 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(543): MediaWiki->main()
#27 /srv/mediawiki/php-1.36.0-wmf.2/index.php(53): MediaWiki->run()
#28 /srv/mediawiki/php-1.36.0-wmf.2/index.php(46): wfIndexMain()
#29 /srv/mediawiki/w/index.php(3): require(string)
#30 {main}
SubjectRepoBranchLines +/-
filebackend: Fix index error in SwiftFileBackendmediawiki/coremaster+14 -8
filebackend: Fix index error in SwiftFileBackendmediawiki/corewmf/1.36.0-wmf.2+14 -8
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedReleasebrennenT257971 1.36.0-wmf.3 deployment blockers
 ResolvedPRODUCTION ERRORthiemowmdeT259023 PHP Notice: Undefined index: content-disposition

Event Timeline

• LarsWirzenius created this task.Jul 28 2020, 1:14 PM
Restricted Application added a project: Commons. · View Herald TranscriptJul 28 2020, 1:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• LarsWirzenius triaged this task as Unbreak Now! priority.Jul 28 2020, 1:14 PM
• LarsWirzenius added a parent task: T257970: 1.36.0-wmf.2 deployment blockers.
• LarsWirzenius mentioned this in T257970: 1.36.0-wmf.2 deployment blockers.

They're still happening: a dozen more while I filed the task.

taavi added subscribers: thiemowmde, taavi.Jul 28 2020, 1:19 PM

cc @thiemowmde as author of 9c6473dc1dca which I believe is causing this.

thiemowmde claimed this task.Jul 28 2020, 1:31 PM
thiemowmde added projects: Regression, Unplanned-Sprint-Work, WMDE-QWERTY-Sprint-2020-07-22.

Uh, indeed. I'm somewhat speechless and can't explain how this happened. Sorry. I uploaded a fix.

gerritbot added a comment.Jul 28 2020, 1:31 PM

Change 616808 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] filebackend: Fix index error in SwiftFileBackend

https://gerrit.wikimedia.org/r/616808

gerritbot added a project: Patch-For-Review.Jul 28 2020, 1:31 PM
thiemowmde added a comment.Jul 28 2020, 1:36 PM

Additional information: I don't think this deserves an "Unbreak Now!". I just tested it again, and the code still does exactly what it is expected to do, even with the bug in place.

• LarsWirzenius lowered the priority of this task from Unbreak Now! to Needs Triage.Jul 28 2020, 1:38 PM

OK, then I'll lower priority and remove as blocker for train. Sorry about the needless alarmism.

• LarsWirzenius removed a parent task: T257970: 1.36.0-wmf.2 deployment blockers.Jul 28 2020, 1:39 PM
Agusbou2015 subscribed.Jul 28 2020, 1:49 PM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-07-22 board.Jul 28 2020, 2:07 PM
• LarsWirzenius added a comment.Jul 28 2020, 4:01 PM

This is still happening on group0 wikis, and it's happening enough that I fear it's going to be a train blocker by tomorrow, before train can go to group1. I hope the change above in Gerrit is a fix, and can be deployed in a backport window before tomorrow's European train window. Is there something that can be done to help that happen?

thiemowmde added a comment.Jul 28 2020, 4:04 PM
  • Yes, I'm sure the patch gets rid of this error.
  • Yes, feel free to backport it. The patch is perfect for a backport, even if it doesn't do much but silencing a notice.
  • No, I'm sorry, but I don't have the capacity to assist such a backport.
gerritbot added a comment.Jul 28 2020, 4:21 PM

Change 616842 had a related patch set uploaded (by Brennen Bearnes; owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@wmf/1.36.0-wmf.2] filebackend: Fix index error in SwiftFileBackend

https://gerrit.wikimedia.org/r/616842

Ammarpad subscribed.Jul 28 2020, 4:28 PM

Lowering the priority gives this task less visibility. It should have been left as UBN at least since it seems the impact is not really negligible.

thcipriani triaged this task as Unbreak Now! priority.Jul 28 2020, 4:47 PM
thcipriani added a parent task: T257970: 1.36.0-wmf.2 deployment blockers.
thcipriani subscribed.

This task is creating logspam, which is a valid reason to hold the train at the deployer's discretion https://wikitech.wikimedia.org/wiki/Deployments/Holding_the_train#Logspam

Leaving as UBN! until a backport is verified in production. Backport looks trivial and seem like it will fix the issue.

gerritbot added a comment.Jul 28 2020, 4:54 PM

Change 616842 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.2] filebackend: Fix index error in SwiftFileBackend

https://gerrit.wikimedia.org/r/616842

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 28 2020, 5:00 PM
Stashbot added a comment.Jul 28 2020, 5:03 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-28T17:03:18Z] <brennen> prior scap sync for https://gerrit.wikimedia.org/r/c/mediawiki/core/+/616842 (T259023)

Stashbot added a comment.Jul 28 2020, 6:05 PM

Mentioned in SAL (#wikimedia-operations) [2020-07-28T18:05:31Z] <catrope@deploy1001> Synchronized php-1.36.0-wmf.2/includes/libs/filebackend/SwiftFileBackend.php: Fix index error in SwiftFileBackend (T259023) (duration: 01m 07s)

brennen edited parent tasks, added: T257971: 1.36.0-wmf.3 deployment blockers; removed: T257970: 1.36.0-wmf.2 deployment blockers.Jul 28 2020, 6:09 PM
brennen subscribed.

This is backported and deployed for 1.36.0-wmf.2; moving to wmf.3 blockers until merged on master.

gerritbot added a comment.Jul 28 2020, 6:52 PM

Change 616808 merged by jenkins-bot:
[mediawiki/core@master] filebackend: Fix index error in SwiftFileBackend

https://gerrit.wikimedia.org/r/616808

Jdforrester-WMF closed this task as Resolved.Jul 28 2020, 6:57 PM
Jdforrester-WMF subscribed.

Let's say this is Resolved for now.

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.3; 2020-08-04); removed MW-1.36-notes (1.36.0-wmf.2; 2020-07-28).Jul 28 2020, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 28 2020, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits