Change 616854 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Skip page content if the result of the form submission is a redirect

https://gerrit.wikimedia.org/r/616854

Change 616854 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Skip page content if the result of the form submission is a redirect

https://gerrit.wikimedia.org/r/616854

@dbarratt @Tchanders Just to check my understanding here.

I setup profiling on my vagrant wiki to see which methods get called when I submit a new target, before and after this change.

Before the change
Profile output for the first POST:

After the change
Profile output for the first POST:

The main difference seems to be that the first POST no longer calls SpecialInvestigate::addTabContent. Otherwise, are we seeing what we want to see?

(Sorry the format isn't necessarily very convenient. Some of the profiling tools are no longer very well supported, so this was the best I could do :))

@dom_walden Yes, that looks right. (I can only see the top 100, but addTabContent would be up there if it were being called.)

In T259032#6345207, @Tchanders wrote:

@dom_walden Yes, that looks right. (I can only see the top 100, but addTabContent would be up there if it were being called.)

Oh, that's a really good point.

Just in case, I rechecked with all the results showing. addTabContent still does not appear.

For a couple of different operations including:

• starting a new investigation
• adding a new target or filter to investigation (this caused the issue in the description)
• changing tabs

I checked that addTabContent is only called once, and only one "query" event is logged.

I also briefly checked that the output appears to be as it should and the DB query getting the data for the Compare or Preliminary Check table is correct.