DiscussionTools tools appear in VE
Closed, ResolvedPublic
Actions

Description

In T258988#6341015, @matmarex wrote:

In T258988, @Ryasmeen wrote:

I noticed an option "Mention a user" under Insert menu. Clicking on which was doing nothing but there was an error in the console.

I can reproduce this. It only happens on pages that load the reply tool (so talk pages, or when using dtenable=1).

Also, and this is probably related, it looks like the option to insert "Your signature" always appears regardless of the namespace.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Do not auto-add "Mention a user" to "Insert" menu	mediawiki/extensions/DiscussionTools	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: T258988: [Regression pre-wmf.2] Map dialog in VE hangs and VE does not open on page reload
Mentioned Here: T258988: [Regression pre-wmf.2] Map dialog in VE hangs and VE does not open on page reload

Event Timeline

ppelberg created this task.Jul 28 2020, 3:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2020, 3:08 PM

ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.Jul 28 2020, 3:09 PM

matmarex updated the task description. (Show Details)Jul 28 2020, 7:16 PM

matmarex mentioned this in T258988: [Regression pre-wmf.2] Map dialog in VE hangs and VE does not open on page reload.

matmarex added a subscriber: Ryasmeen.

Also, and this is probably related, it looks like the option to insert "Your signature" always appears regardless of the namespace.

I think this is actually intentional, or at least not a recent regression. I just never noticed it before.

Change 616898 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Do not auto-add "Mention a user" to "Insert" menu

https://gerrit.wikimedia.org/r/616898

gerritbot added a project: Patch-For-Review.Jul 28 2020, 7:43 PM

matmarex claimed this task.Jul 28 2020, 7:43 PM

matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.

In T259039#6342445, @matmarex wrote:

Also, and this is probably related, it looks like the option to insert "Your signature" always appears regardless of the namespace.

I think this is actually intentional, or at least not a recent regression. I just never noticed it before.

Yeah, it's been like that for at least last 3 years. I knew it was intentionally added there. Forgot the the reason though.

Change 616898 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Do not auto-add "Mention a user" to "Insert" menu

https://gerrit.wikimedia.org/r/616898

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 29 2020, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2020, 3:10 PM

ppelberg moved this task from Needs Prioritization to Required for Release on the OWC2020 (Reply Tool Opt Out) board.Jul 29 2020, 3:51 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Jul 29 2020, 4:51 PM

matmarex added a project: Editing QA.

ppelberg moved this task from Required for Release to Required after release on the OWC2020 (Reply Tool Opt Out) board.Jul 29 2020, 5:00 PM

Hey @Ryasmeen , we are in Board Refinement and @matmarex said he fixed this, so T258988 should no longer be blocked. Can you confirm this and move it to @ppelberg column if it is resolved or show him what you're running into if it is not during your 1:1?

Ryasmeen triaged this task as High priority.Jul 29 2020, 8:17 PM

This is now fixed and so are all the other issues I was running into in T258988.

In T259039#6346720, @Ryasmeen wrote:

This is now fixed and so are all the other issues I was running into in T258988.

Excellent. Thank you for confirming, Rummana.

ppelberg closed this task as Resolved.Jul 30 2020, 12:04 AM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 30 2020, 12:04 AM

DiscussionTools tools appear in VEClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

DiscussionTools tools appear in VE
Closed, ResolvedPublic
Actions