Page MenuHomePhabricator

Update wikibase.ui.entitysearch, wikibase.ui.entityViewInit, jquery.wikibase.toolbar.styles and wikibase.common to define targets and be aware of mobile
Open, Needs TriagePublic

Description

The modules wikibase.common, wikibase.ui.entityViewInit, jquery.wikibase.toolbar.styles and wikibase.ui.entitysearch are loaded on Minerva desktop (https://www.wikidata.org/wiki/Q83200962?useskin=minerva) but silently removed on Minerva mobile via the targets system. Silent removals lead to warnings per T235712.

Please set targets on the module to ensure this code is loaded on mobile or update the mechanism for adding the module to the page based on skin (if it's not meant to load in Minerva). Note you can add handling for mobile based on feature detection inside the module itself (e.g. screen resolution or 'ontouchstart' in document.documentElement;) if the code should not run on mobile devices but should be loaded.

Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptJul 28 2020, 4:32 PM
Jdlrobson renamed this task from Update wikibase.ui.entitysearch to define targets and be aware of mobile to Update wikibase.ui.entitysearch, wikibase.ui.entityViewInit, jquery.wikibase.toolbar.styles and wikibase.common to define targets and be aware of mobile.Jul 28 2020, 4:37 PM
Jdlrobson updated the task description. (Show Details)